[net-next,S3,01/13] i40evf: fix bad indentation
diff mbox

Message ID 1428450342-48517-1-git-send-email-catherine.sullivan@intel.com
State Accepted
Delegated to: Jeff Kirsher
Headers show

Commit Message

Catherine Sullivan April 7, 2015, 11:45 p.m. UTC
From: Mitch Williams <mitch.a.williams@intel.com>

Not sure how this slipped through. Cosmetic change only.

Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Change-ID: Iefec17e6bc14985d8cb7925c0bac770aa37de7c9
---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Kirsher April 7, 2015, 11:52 p.m. UTC | #1
On Tue, 2015-04-07 at 19:45 -0400, Catherine Sullivan wrote:
> From: Mitch Williams <mitch.a.williams@intel.com>
> 
> Not sure how this slipped through. Cosmetic change only.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
> Change-ID: Iefec17e6bc14985d8cb7925c0bac770aa37de7c9
> ---
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Catherine, I have added your patch to my queue.
Alexander Duyck April 8, 2015, 1:37 a.m. UTC | #2
On 04/07/2015 04:52 PM, Jeff Kirsher wrote:
> On Tue, 2015-04-07 at 19:45 -0400, Catherine Sullivan wrote:
>> From: Mitch Williams <mitch.a.williams@intel.com>
>>
>> Not sure how this slipped through. Cosmetic change only.
>>
>> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
>> Change-ID: Iefec17e6bc14985d8cb7925c0bac770aa37de7c9
>> ---
>>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> Thanks Catherine, I have added your patch to my queue.

When you guys send out these series, and have Jeff just reply to every
patch it quickly bloats a 13 patch series over 26 emails.   Any chance
of getting a 00/XX patch with maybe a simple note such as "i40e
updates", and then just have Jeff reply to that?  Otherwise this is
going to probably just degenerate into noise as all of the patches being
replied to makes this kind of hard to review.

- Alex
Jeff Kirsher April 8, 2015, 1:45 a.m. UTC | #3
On Tue, 2015-04-07 at 18:37 -0700, Alexander Duyck wrote:
> On 04/07/2015 04:52 PM, Jeff Kirsher wrote:
> > On Tue, 2015-04-07 at 19:45 -0400, Catherine Sullivan wrote:
> >> From: Mitch Williams <mitch.a.williams@intel.com>
> >>
> >> Not sure how this slipped through. Cosmetic change only.
> >>
> >> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
> >> Change-ID: Iefec17e6bc14985d8cb7925c0bac770aa37de7c9
> >> ---
> >>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > Thanks Catherine, I have added your patch to my queue.
> 
> When you guys send out these series, and have Jeff just reply to every
> patch it quickly bloats a 13 patch series over 26 emails.   Any chance
> of getting a 00/XX patch with maybe a simple note such as "i40e
> updates", and then just have Jeff reply to that?  Otherwise this is
> going to probably just degenerate into noise as all of the patches
> being
> replied to makes this kind of hard to review.

I was thinking the same thing Alex.  I will work with Catherine (and the
others) to generate a cover patch for patches in a series.
James Young April 13, 2015, 9:10 p.m. UTC | #4
-----Original Message-----
From: Kirsher, Jeffrey T 
Sent: Tuesday, April 07, 2015 4:53 PM
To: Sullivan, Catherine; Young, James M
Cc: intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [net-next S3 01/13] i40evf: fix bad indentation

On Tue, 2015-04-07 at 19:45 -0400, Catherine Sullivan wrote:
> From: Mitch Williams <mitch.a.williams@intel.com>
> 
> Not sure how this slipped through. Cosmetic change only.
> 
> Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
> Change-ID: Iefec17e6bc14985d8cb7925c0bac770aa37de7c9
> ---
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Catherine, I have added your patch to my queue.

Patch
diff mbox

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 6d5f3b2..a31bfd1 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -2029,7 +2029,7 @@  static void i40evf_init_task(struct work_struct *work)
 		if (err) {
 			dev_err(&pdev->dev, "Failed to set MAC type (%d)\n",
 				err);
-		goto err;
+			goto err;
 		}
 		err = i40evf_check_reset_complete(hw);
 		if (err) {