diff mbox

[1/1,v2] libvpx: bump version to 1.4.0

Message ID 1428447211-24428-1-git-send-email-sagaert.johan@proximus.be
State Accepted
Headers show

Commit Message

Johan Sagaert April 7, 2015, 10:53 p.m. UTC
Use tar.bz2 instead of git.
Also added the hash file.
Changes: https://chromium.googlesource.com/webm/libvpx/+/0080aca235e2d677e49ff46c3e8e77d9dd15858c/CHANGELOG

Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>
---
V1->V2
	Use tar.bz2 and add hash.
---
 package/libvpx/libvpx.hash | 2 ++
 package/libvpx/libvpx.mk   | 9 ++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)
 create mode 100644 package/libvpx/libvpx.hash

Comments

Arnout Vandecappelle April 8, 2015, 8:11 p.m. UTC | #1
On 08/04/15 00:53, Sagaert Johan wrote:
> Use tar.bz2 instead of git.
> Also added the hash file.
> Changes: https://chromium.googlesource.com/webm/libvpx/+/0080aca235e2d677e49ff46c3e8e77d9dd15858c/CHANGELOG
> 
> Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>

Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 (build test, including check that ffmpeg links against it)

> ---
> V1->V2
> 	Use tar.bz2 and add hash.
> ---
>  package/libvpx/libvpx.hash | 2 ++
>  package/libvpx/libvpx.mk   | 9 ++++-----
>  2 files changed, 6 insertions(+), 5 deletions(-)
>  create mode 100644 package/libvpx/libvpx.hash
> 
> diff --git a/package/libvpx/libvpx.hash b/package/libvpx/libvpx.hash
> new file mode 100644
> index 0000000..44cd994
> --- /dev/null
> +++ b/package/libvpx/libvpx.hash
> @@ -0,0 +1,2 @@
> +# Locally computed:
> +sha256  f582d9b2d60a592a4a3d8c32965ca2d2167e9ade38c6c30bac8801ff66a118e4  libvpx-1.4.0.tar.bz2
> diff --git a/package/libvpx/libvpx.mk b/package/libvpx/libvpx.mk
> index 7624835..a6a6d83 100644
> --- a/package/libvpx/libvpx.mk
> +++ b/package/libvpx/libvpx.mk
> @@ -4,13 +4,12 @@
>  #
>  ################################################################################
>  
> -LIBVPX_VERSION = v1.3.0
> -LIBVPX_SITE = http://git.chromium.org/webm/libvpx.git
> -LIBVPX_SITE_METHOD = git
> -
> +LIBVPX_VERSION_MAJOR = 1.4
> +LIBVPX_VERSION = $(LIBVPX_VERSION_MAJOR).0

 There is no need to introduce the LIBVPX_VERSION_MAJOR symbol. Just define the
version as 1.4.0.


 Regards,
 Arnout

> +LIBVPX_SOURCE = libvpx-$(LIBVPX_VERSION).tar.bz2
> +LIBVPX_SITE = http://storage.googleapis.com/downloads.webmproject.org/releases/webm
>  LIBVPX_LICENSE = BSD-3c
>  LIBVPX_LICENSE_FILES = LICENSE PATENTS
> -
>  LIBVPX_INSTALL_STAGING = YES
>  
>  # ld is being used with cc options. therefore, pretend ld is cc.
>
Thomas Petazzoni April 8, 2015, 8:51 p.m. UTC | #2
Dear Sagaert Johan,

On Wed,  8 Apr 2015 00:53:31 +0200, Sagaert Johan wrote:
> Use tar.bz2 instead of git.
> Also added the hash file.
> Changes: https://chromium.googlesource.com/webm/libvpx/+/0080aca235e2d677e49ff46c3e8e77d9dd15858c/CHANGELOG
> 
> Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>

Thanks, applied, after removing the unnecessary LIBVPX_VERSION_MAJOR
variable, as suggested by Arnout.

Thomas
Johan Sagaert April 8, 2015, 10:45 p.m. UTC | #3
Thomas Petazzoni schreef op 8/04/2015 om 22:51:
> Dear Sagaert Johan,
>
> On Wed,  8 Apr 2015 00:53:31 +0200, Sagaert Johan wrote:
>> Use tar.bz2 instead of git.
>> Also added the hash file.
>> Changes: https://chromium.googlesource.com/webm/libvpx/+/0080aca235e2d677e49ff46c3e8e77d9dd15858c/CHANGELOG
>>
>> Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>
> Thanks, applied, after removing the unnecessary LIBVPX_VERSION_MAJOR
> variable, as suggested by Arnout.
>
> Thomas
Dear Thomas

Fine, thanks :
Is there a thumb rule  when this is needed  ?  I see many packages use 
this scheme .

Regards, Johan
Baruch Siach April 9, 2015, 4:43 a.m. UTC | #4
Hi Johan,

On Thu, Apr 09, 2015 at 12:45:07AM +0200, Johan Sagaert wrote:
> Thomas Petazzoni schreef op 8/04/2015 om 22:51:
> >On Wed,  8 Apr 2015 00:53:31 +0200, Sagaert Johan wrote:
> >>Use tar.bz2 instead of git.
> >>Also added the hash file.
> >>Changes: https://chromium.googlesource.com/webm/libvpx/+/0080aca235e2d677e49ff46c3e8e77d9dd15858c/CHANGELOG
> >>
> >>Signed-off-by: Sagaert Johan <sagaert.johan@proximus.be>
> >Thanks, applied, after removing the unnecessary LIBVPX_VERSION_MAJOR
> >variable, as suggested by Arnout.
>
> Fine, thanks :
> Is there a thumb rule  when this is needed  ?  I see many packages use this
> scheme .

We split the _MAJOR part of the version when it is used on its one, e.g. for 
_SITE name.

baruch
diff mbox

Patch

diff --git a/package/libvpx/libvpx.hash b/package/libvpx/libvpx.hash
new file mode 100644
index 0000000..44cd994
--- /dev/null
+++ b/package/libvpx/libvpx.hash
@@ -0,0 +1,2 @@ 
+# Locally computed:
+sha256  f582d9b2d60a592a4a3d8c32965ca2d2167e9ade38c6c30bac8801ff66a118e4  libvpx-1.4.0.tar.bz2
diff --git a/package/libvpx/libvpx.mk b/package/libvpx/libvpx.mk
index 7624835..a6a6d83 100644
--- a/package/libvpx/libvpx.mk
+++ b/package/libvpx/libvpx.mk
@@ -4,13 +4,12 @@ 
 #
 ################################################################################
 
-LIBVPX_VERSION = v1.3.0
-LIBVPX_SITE = http://git.chromium.org/webm/libvpx.git
-LIBVPX_SITE_METHOD = git
-
+LIBVPX_VERSION_MAJOR = 1.4
+LIBVPX_VERSION = $(LIBVPX_VERSION_MAJOR).0
+LIBVPX_SOURCE = libvpx-$(LIBVPX_VERSION).tar.bz2
+LIBVPX_SITE = http://storage.googleapis.com/downloads.webmproject.org/releases/webm
 LIBVPX_LICENSE = BSD-3c
 LIBVPX_LICENSE_FILES = LICENSE PATENTS
-
 LIBVPX_INSTALL_STAGING = YES
 
 # ld is being used with cc options. therefore, pretend ld is cc.