From patchwork Tue Apr 7 15:49:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 458701 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8C2461401DD for ; Wed, 8 Apr 2015 01:50:15 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=sourceware.org header.i=@sourceware.org header.b=Fq71gsCH; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type; q=dns; s=default; b=oygCUQ VFQO3m0lkwM3zcPvU9JbuF/tLeMYfe5Z9yX9qnWR81iK5l6res4/VD98Xpq3U8r8 qA8BbizAUsu0uWWeX/YiXNGiwgWz9nfhMKCQ7gvln+IOoaY8L6VdUoove+wvAegT LynIC4gbot1b6fFnVNDLUqbRl8yFoE1FFQ7Zs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :references:in-reply-to:content-type; s=default; bh=VVpLjZdbepB8 rorV3mVAQPn86vo=; b=Fq71gsCH+5BpsWruQxqeiax4BX1unkT5MzTnFxWeosVC /VkokFZ705kIXm24U7wbQWFFJvEMQiErvhwIDklO18A8yPVvP9BP7/h3o4GGlJ+V im7DD5ZONQBX/i1KWGO04ZlbZaWNYoN1rX/RhbPhGddfgGFbc2ip1FHE2g2DT2A= Received: (qmail 89236 invoked by alias); 7 Apr 2015 15:50:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 89224 invoked by uid 89); 7 Apr 2015 15:50:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL, BAYES_00, SPF_HELO_PASS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <5523FCA6.2080504@redhat.com> Date: Tue, 07 Apr 2015 17:49:58 +0200 From: Florian Weimer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Stefan Liebler , libc-alpha@sourceware.org Subject: Re: [PATCH 06/25] Add struct scratch_buffer and its internal helper functions References: <7a6fe503fb764beee3d5b89662d3bbf65242161c.1425285061.git.fweimer@redhat.com> <54F4BB15.7070409@cs.ucla.edu> <550C37F7.10504@redhat.com> <550C4AE0.60205@cs.ucla.edu> <55103BEA.7070305@redhat.com> <5510505B.8060209@cs.ucla.edu> <55105F2C.6040400@redhat.com> <55105FED.80004@redhat.com> <551C1C9B.1060807@redhat.com> <551D8AE1.5000805@redhat.com> <551DE8EA.6080200@cs.ucla.edu> <5522BC03.5090300@redhat.com> <5523007D.9080906@cs.ucla.edu> <55239F13.5040700@redhat.com> <5523EABF.9050003@redhat.com> In-Reply-To: <5523EABF.9050003@redhat.com> On 04/07/2015 04:33 PM, Florian Weimer wrote: > On 04/07/2015 03:18 PM, Stefan Liebler wrote: >> Hi Florian, >> >> i get a build error on s390x: >> gcc scratch_buffer_grow_preserve.c -c >> ... >> scratch_buffer_grow_preserve.c: In function >> ‘__libc_scratch_buffer_grow_preserve’: >> scratch_buffer_grow_preserve.c:35:7: error: implicit declaration of >> function ‘memcpy’ [-Werror=implicit-function-declaration] >> memcpy (new_ptr, buffer->__space, buffer->length); >> ^ >> scratch_buffer_grow_preserve.c:35:7: error: incompatible implicit >> declaration of built-in function ‘memcpy’ [-Werror] >> cc1: all warnings being treated as errors >> >> #include in malloc/scratch_buffer_grow_preserve.c solves this >> error. Please update scratch_buffer_grow_preserve.c. > > Sorry about that. I did build on ppc64, but building on s390x is > difficult for me due to the binutils 2.24 requirement. I'm trying to > get a suitable machine reservation, but I'm not sure if that will succeed. > > Should I commit this fix blindly, without testing it on s390x? I found a machine to test this on, so I committed the attached patch. From 72301304a5655662baf2bae88a7aceeabc4a753e Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Tue, 7 Apr 2015 17:46:58 +0200 Subject: [PATCH] scratch_buffer_grow_preserve: Add missing #include --- ChangeLog | 4 ++++ malloc/scratch_buffer_grow_preserve.c | 1 + 2 files changed, 5 insertions(+) diff --git a/ChangeLog b/ChangeLog index 4e1df07..c0d3aca 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2015-04-07 Florian Weimer + * malloc/scratch_buffer_grow_preserve.c: Include + +2015-04-07 Florian Weimer + * include/scratch_buffer.h: New file. * malloc/scratch_buffer_grow.c: Likewise. * malloc/scratch_buffer_grow_preserve.c: Likewise. diff --git a/malloc/scratch_buffer_grow_preserve.c b/malloc/scratch_buffer_grow_preserve.c index f2edb49..c5f0b2d 100644 --- a/malloc/scratch_buffer_grow_preserve.c +++ b/malloc/scratch_buffer_grow_preserve.c @@ -18,6 +18,7 @@ #include #include +#include bool __libc_scratch_buffer_grow_preserve (struct scratch_buffer *buffer) -- 2.1.0