Patchwork QEMU kill CR3_CACHE references

login
register
mail settings
Submitter Jes Sorensen
Date Feb. 19, 2010, 6:43 a.m.
Message ID <4B7E330C.4090302@redhat.com>
Download mbox | patch
Permalink /patch/45841/
State New
Headers show

Comments

Jes Sorensen - Feb. 19, 2010, 6:43 a.m.
Hi,

The CR3 caching was never implemented in QEMU and is obsoleted by
NPT/EPT. This patch removes the unused references to it from
target-i386/kvm.c.

Cheers,
Jes
commit 5ed16687929511d015dd3542c4359cabe170401a
Author: Jes Sorensen <Jes.Sorensen@redhat.com>
Date:   Fri Feb 19 07:39:56 2010 +0100

    Remove all references to KVM_CR3_CACHE as it was never implemented.
    
    Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Zachary Amsden - Feb. 19, 2010, 9:46 a.m.
> Hi,
>
> The CR3 caching was never implemented in QEMU and is obsoleted by
> NPT/EPT. This patch removes the unused references to it from
> target-i386/kvm.c. 

This feature was broken by design.  Glad to see it go.

Zach
Anthony Liguori - Feb. 19, 2010, 8:57 p.m.
On 02/19/2010 12:43 AM, Jes Sorensen wrote:
> Hi,
>
> The CR3 caching was never implemented in QEMU and is obsoleted by
> NPT/EPT. This patch removes the unused references to it from
> target-i386/kvm.c.

Let's bring this through uq/master?  Sound reasonable Marcelo?

Regards,

Anthony Liguori

> Cheers,
> Jes
>
Avi Kivity - Feb. 21, 2010, 9:41 a.m.
On 02/19/2010 08:43 AM, Jes Sorensen wrote:
> Hi,
>
> The CR3 caching was never implemented in QEMU and is obsoleted by
> NPT/EPT. This patch removes the unused references to it from
> target-i386/kvm.c.
>

Applied, thanks.

Patch

diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 0d08cd5..5d9aecc 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -158,9 +158,6 @@  struct kvm_para_features {
 #ifdef KVM_CAP_PV_MMU
         { KVM_CAP_PV_MMU, KVM_FEATURE_MMU_OP },
 #endif
-#ifdef KVM_CAP_CR3_CACHE
-        { KVM_CAP_CR3_CACHE, KVM_FEATURE_CR3_CACHE },
-#endif
         { -1, -1 }
 };