diff mbox

[iptables] ebtables-compat: fix misplaced function attribute on ebt_print_error()

Message ID 20150406140528.30059.48340.stgit@nfdev2.cica.es
State Accepted
Delegated to: Pablo Neira
Headers show

Commit Message

Arturo Borrero April 6, 2015, 2:05 p.m. UTC 
From: Arturo Borrero Gonzalez <aborrero@nfdev2.cica.es>

xtables-eb.c:305:1: warning: empty declaration
 } __attribute__((noreturn, format(printf,2,3)));
 ^
xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
  .exit_err  = ebt_print_error,
  ^

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
---
 iptables/xtables-eb.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Pablo Neira Ayuso April 8, 2015, 5:03 p.m. UTC | #1 
On Mon, Apr 06, 2015 at 04:05:28PM +0200, Arturo Borrero Gonzalez wrote:
> From: Arturo Borrero Gonzalez <aborrero@nfdev2.cica.es>
> 
> xtables-eb.c:305:1: warning: empty declaration
>  } __attribute__((noreturn, format(printf,2,3)));
>  ^
> xtables-eb.c:311:2: warning: initialization makes '__attribute__((noreturn))' qualified function pointer from unqualified
>   .exit_err  = ebt_print_error,
>   ^

Applied, thanks Arturo.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/iptables/xtables-eb.c b/iptables/xtables-eb.c
index ddef14a..c8b5d4f 100644
--- a/iptables/xtables-eb.c
+++ b/iptables/xtables-eb.c
@@ -292,7 +292,7 @@  static struct option ebt_original_options[] =
 	{ 0 }
 };
 
-static void
+static void __attribute__((__noreturn__,format(printf,2,3)))
 ebt_print_error(enum xtables_exittype status, const char *format, ...)
 {
 	va_list l;
@@ -302,7 +302,7 @@  ebt_print_error(enum xtables_exittype status, const char *format, ...)
 	fprintf(stderr, ".\n");
 	va_end(l);
 	exit(-1);
-} __attribute__((noreturn, format(printf,2,3)));
+}
 
 struct xtables_globals ebtables_globals = {
 	.option_offset 		= 0,