diff mbox

[U-Boot,v2,06/11] Avoid calling print_eths() with driver model

Message ID 1428271663-3814-7-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass April 5, 2015, 10:07 p.m. UTC 
This function is not supported with driver model.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
---
Note from Joe Hershberger <joe.hershberger@ni.com>

At this point I don't see much value in listing the Ethernet devices in
bdinfo. It seems like a bit of a spurious thing to display and as such I
didn't feel like rewriting it to be compatible with DM or implementing the
functions bdinfo's print_eths() uses.  Also, it is only supported on ARM
and Microblaze. The inconsistency also led to my decision to drop it.

Changes in v2: None

 common/cmd_bdinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass April 9, 2015, 3:04 a.m. UTC | #1 
On 5 April 2015 at 16:07, Simon Glass <sjg@chromium.org> wrote:
> This function is not supported with driver model.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
> ---
> Note from Joe Hershberger <joe.hershberger@ni.com>
>
> At this point I don't see much value in listing the Ethernet devices in
> bdinfo. It seems like a bit of a spurious thing to display and as such I
> didn't feel like rewriting it to be compatible with DM or implementing the
> functions bdinfo's print_eths() uses.  Also, it is only supported on ARM
> and Microblaze. The inconsistency also led to my decision to drop it.
>
> Changes in v2: None
>
>  common/cmd_bdinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to u-boot-dm/next.
diff mbox

Patch

diff --git a/common/cmd_bdinfo.c b/common/cmd_bdinfo.c
index b4cce25..f16d5c7 100644
--- a/common/cmd_bdinfo.c
+++ b/common/cmd_bdinfo.c
@@ -377,7 +377,7 @@  static int do_bdinfo(cmd_tbl_t *cmdtp, int flag, int argc,
 		print_num("-> size",	bd->bi_dram[i].size);
 	}
 
-#if defined(CONFIG_CMD_NET)
+#if defined(CONFIG_CMD_NET) && !defined(CONFIG_DM_ETH)
 	print_eths();
 #endif
 	printf("baudrate    = %u bps\n", gd->baudrate);