diff mbox

[PULL,3/5] target-tricore: Fix check which was always false

Message ID 7b4b0b5795e934a9b7efb916af86715b68555be9.1428131273.git.mjt@msgid.tls.msk.ru
State New
Headers show

Commit Message

Michael Tokarev April 4, 2015, 7:10 a.m. UTC 
From: Stefan Weil <sw@weilnetz.de>

With a mask value of 0x00400000, the result will never be 1.
This fixes a Coverity warning.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 target-tricore/op_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c
index 220ec4a..9907e07 100644
--- a/target-tricore/op_helper.c
+++ b/target-tricore/op_helper.c
@@ -2573,7 +2573,7 @@  void helper_rslcx(CPUTriCoreState *env)
         /* CSU trap */
     }
     /* if (PCXI.UL == 1) then trap(CTYP); */
-    if ((env->PCXI & MASK_PCXI_UL) == 1) {
+    if ((env->PCXI & MASK_PCXI_UL) != 0) {
         /* CTYP trap */
     }
     /* EA = {PCXI.PCXS, 6'b0, PCXI.PCXO, 6'b0}; */