diff mbox

toolchains: remove non-LFS toolchain

Message ID 1428057549-24019-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Headers show

Commit Message

Yann E. MORIN April 3, 2015, 10:39 a.m. UTC
Buildroot now requires toolchains to have LFS; it's no longer optional.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
 1 file changed, 9 deletions(-)
 delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config

Comments

Baruch Siach April 3, 2015, 10:44 a.m. UTC | #1
Hi Yann,

On Fri, Apr 03, 2015 at 12:39:09PM +0200, Yann E. MORIN wrote:
> Buildroot now requires toolchains to have LFS; it's no longer optional.

Why not just rebuild this toolchain using current master with LFS?

baruch

> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
>  1 file changed, 9 deletions(-)
>  delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config
> 
> diff --git a/web/toolchains/configs/br-powerpc-603e-basic-cpp.config b/web/toolchains/configs/br-powerpc-603e-basic-cpp.config
> deleted file mode 100644
> index 9f1eb82..0000000
> --- a/web/toolchains/configs/br-powerpc-603e-basic-cpp.config
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -BR2_powerpc=y
> -BR2_powerpc_603e=y
> -BR2_TOOLCHAIN_EXTERNAL=y
> -BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> -BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> -BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-powerpc-603e-basic-cpp-2015.02.tar.bz2"
> -BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_18=y
> -# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
> -BR2_TOOLCHAIN_EXTERNAL_CXX=y
Thomas Petazzoni April 3, 2015, 12:26 p.m. UTC | #2
Dear Yann E. MORIN,

On Fri,  3 Apr 2015 12:39:09 +0200, Yann E. MORIN wrote:
> Buildroot now requires toolchains to have LFS; it's no longer optional.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
>  1 file changed, 9 deletions(-)
>  delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config

Thanks, applied. However, you forgot to also update the CSV file that
lists all toolchain (so I did that). And next time if you could
--subject-prefix="buildroot-test" or something like that, it would be
great, as it allows to more clearly distinguish such patches from real
Buildroot patches.

Thanks!

Thomas
Thomas Petazzoni April 3, 2015, 12:27 p.m. UTC | #3
Dear Baruch Siach,

On Fri, 3 Apr 2015 13:44:32 +0300, Baruch Siach wrote:
> Hi Yann,
> 
> On Fri, Apr 03, 2015 at 12:39:09PM +0200, Yann E. MORIN wrote:
> > Buildroot now requires toolchains to have LFS; it's no longer optional.
> 
> Why not just rebuild this toolchain using current master with LFS?

That's the plan, but until this is done, to fix autobuilder issues,
let's disable this toolchain.

I will rebuild the ARM and PowerPC basic toolchains, and also the SH4
toolchain after applying Waldemar's fix, and then update the
autobuilder configuration accordingly.

Thanks!

Thomas
Yann E. MORIN April 3, 2015, 12:38 p.m. UTC | #4
Thomas, All,

On 2015-04-03 14:26 +0200, Thomas Petazzoni spake thusly:
> On Fri,  3 Apr 2015 12:39:09 +0200, Yann E. MORIN wrote:
> > Buildroot now requires toolchains to have LFS; it's no longer optional.
> > 
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> > ---
> >  web/toolchains/configs/br-powerpc-603e-basic-cpp.config | 9 ---------
> >  1 file changed, 9 deletions(-)
> >  delete mode 100644 web/toolchains/configs/br-powerpc-603e-basic-cpp.config
> 
> Thanks, applied. However, you forgot to also update the CSV file that
> lists all toolchain (so I did that).

Damn, thanks.

> And next time if you could
> --subject-prefix="buildroot-test" or something like that, it would be
> great, as it allows to more clearly distinguish such patches from real
> Buildroot patches.

Well, here's what I did:
    git send-email HEAD^ --to buildroot --suffix='autobuild'

hoping to get something like [PATCH 1/1 autobuild] blabla

But looking at the docs, it's not a send-email option, it's a
format-patch option. Still it did auto-compete it. Damn... Sorry.

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/web/toolchains/configs/br-powerpc-603e-basic-cpp.config b/web/toolchains/configs/br-powerpc-603e-basic-cpp.config
deleted file mode 100644
index 9f1eb82..0000000
--- a/web/toolchains/configs/br-powerpc-603e-basic-cpp.config
+++ /dev/null
@@ -1,9 +0,0 @@ 
-BR2_powerpc=y
-BR2_powerpc_603e=y
-BR2_TOOLCHAIN_EXTERNAL=y
-BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
-BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
-BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-powerpc-603e-basic-cpp-2015.02.tar.bz2"
-BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_18=y
-# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
-BR2_TOOLCHAIN_EXTERNAL_CXX=y