From patchwork Wed Feb 17 21:15:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: gregkh@suse.de X-Patchwork-Id: 45671 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8F0DBB7C09 for ; Thu, 18 Feb 2010 08:15:24 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756552Ab0BQVPT (ORCPT ); Wed, 17 Feb 2010 16:15:19 -0500 Received: from kroah.org ([198.145.64.141]:50753 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756496Ab0BQVPS (ORCPT ); Wed, 17 Feb 2010 16:15:18 -0500 Received: from localhost (c-98-246-45-209.hsd1.or.comcast.net [98.246.45.209]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id 578C448A19; Wed, 17 Feb 2010 13:15:17 -0800 (PST) Subject: patch net-move-am79c961-s-probe-function-to-.devinit.text.patch added to gregkh-2.6 tree To: u.kleine-koenig@pengutronix.de, 12o3l@tiscali.nl, akpm@linux-foundation.org, gregkh@suse.de, netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk From: Date: Wed, 17 Feb 2010 13:15:00 -0800 In-Reply-To: <1265313417-5568-9-git-send-email-u.kleine-koenig@pengutronix.de> Message-ID: <12664413002764@kroah.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This is a note to let you know that I've just added the patch titled Subject: net: move am79c961's probe function to .devinit.text to my gregkh-2.6 tree. Its filename is net-move-am79c961-s-probe-function-to-.devinit.text.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ From u.kleine-koenig@pengutronix.de Wed Feb 17 12:45:57 2010 From: Uwe Kleine-König Date: Thu, 4 Feb 2010 20:56:57 +0100 Subject: net: move am79c961's probe function to .devinit.text To: Greg KH Cc: Roel Kluin <12o3l@tiscali.nl>, Russell King , netdev@vger.kernel.org, Andrew Morton Message-ID: <1265313417-5568-9-git-send-email-u.kleine-koenig@pengutronix.de> From: Uwe Kleine-König A pointer to am79c961_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König Cc: Roel Kluin <12o3l@tiscali.nl> Cc: Russell King Cc: Cc: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/net/arm/am79c961a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/arm/am79c961a.c +++ b/drivers/net/arm/am79c961a.c @@ -680,7 +680,7 @@ static const struct net_device_ops am79c #endif }; -static int __init am79c961_probe(struct platform_device *pdev) +static int __devinit am79c961_probe(struct platform_device *pdev) { struct resource *res; struct net_device *dev;