| Message ID | 12664413002764@kroah.org |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
--- a/drivers/net/arm/am79c961a.c +++ b/drivers/net/arm/am79c961a.c @@ -680,7 +680,7 @@ static const struct net_device_ops am79c #endif }; -static int __init am79c961_probe(struct platform_device *pdev) +static int __devinit am79c961_probe(struct platform_device *pdev) { struct resource *res; struct net_device *dev;
This is a note to let you know that I've just added the patch titled Subject: net: move am79c961's probe function to .devinit.text to my gregkh-2.6 tree. Its filename is net-move-am79c961-s-probe-function-to-.devinit.text.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ From u.kleine-koenig@pengutronix.de Wed Feb 17 12:45:57 2010 From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Date: Thu, 4 Feb 2010 20:56:57 +0100 Subject: net: move am79c961's probe function to .devinit.text To: Greg KH <gregkh@suse.de> Cc: Roel Kluin <12o3l@tiscali.nl>, Russell King <rmk+kernel@arm.linux.org.uk>, netdev@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org> Message-ID: <1265313417-5568-9-git-send-email-u.kleine-koenig@pengutronix.de> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> A pointer to am79c961_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Roel Kluin <12o3l@tiscali.nl> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Cc: <netdev@vger.kernel.org> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/net/arm/am79c961a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html