[Trusty] ALSA: hda - Add one more node in the EAPD supporting candidate list
diff mbox

Message ID 1427782781-15300-1-git-send-email-hui.wang@canonical.com
State New
Headers show

Commit Message

Hui Wang March 31, 2015, 6:19 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1436745

We have a HP machine which use the codec node 0x17 connecting the
internal speaker, and from the node capability, we saw the EAPD,
if we don't set the EAPD on for this node, the internal speaker
can't output any sound.

Cc: <stable@vger.kernel.org>
BugLink: https://bugs.launchpad.net/bugs/1436745
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit af95b41426e0b58279f8ff0ebe420df49a4e96b8)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Bader March 31, 2015, 9 a.m. UTC | #1
On 31.03.2015 08:19, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1436745
> 
> We have a HP machine which use the codec node 0x17 connecting the
> internal speaker, and from the node capability, we saw the EAPD,
> if we don't set the EAPD on for this node, the internal speaker
> can't output any sound.
> 
> Cc: <stable@vger.kernel.org>

Both, Trusty and Utopic seem to be able to cherry pick the same patch. So it
would be sufficient to send it once with T and U in the subject. But since those
are upstream stable tagged the change should be automatically picked up. The
change looks sufficiently simple. I am leaving the decision about which route to
take to the stable team.

-Stefan
Kamal Mostafa March 31, 2015, 4:59 p.m. UTC | #2
On Tue, 2015-03-31 at 11:00 +0200, Stefan Bader wrote:
> On 31.03.2015 08:19, Hui Wang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1436745
> > 
> > We have a HP machine which use the codec node 0x17 connecting the
> > internal speaker, and from the node capability, we saw the EAPD,
> > if we don't set the EAPD on for this node, the internal speaker
> > can't output any sound.
> > 
> > Cc: <stable@vger.kernel.org>
> 
> Both, Trusty and Utopic seem to be able to cherry pick the same patch. So it
> would be sufficient to send it once with T and U in the subject. But since those
> are upstream stable tagged the change should be automatically picked up. The
> change looks sufficiently simple. I am leaving the decision about which route to
> take to the stable team.
> 
> -Stefan
> 
> 

I will queue this up for the next 3.13-stable (v3.13.11-ckt18), so
Trusty can just pick it up from there.

Thanks Hui and Stefan!

 -Kamal
Brad Figg March 31, 2015, 5:04 p.m. UTC | #3
On Tue, Mar 31, 2015 at 02:19:39PM +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1436745
> 
> We have a HP machine which use the codec node 0x17 connecting the
> internal speaker, and from the node capability, we saw the EAPD,
> if we don't set the EAPD on for this node, the internal speaker
> can't output any sound.
> 
> Cc: <stable@vger.kernel.org>
> BugLink: https://bugs.launchpad.net/bugs/1436745
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit af95b41426e0b58279f8ff0ebe420df49a4e96b8)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 113f15c..deec881 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -270,7 +270,7 @@ static void alc_auto_setup_eapd(struct hda_codec *codec, bool on)
>  {
>  	/* We currently only handle front, HP */
>  	static hda_nid_t pins[] = {
> -		0x0f, 0x10, 0x14, 0x15, 0
> +		0x0f, 0x10, 0x14, 0x15, 0x17, 0
>  	};
>  	hda_nid_t *p;
>  	for (p = pins; *p; p++)
> -- 
> 1.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

We'll pull this in vial stable upstream update.

Patch
diff mbox

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 113f15c..deec881 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -270,7 +270,7 @@  static void alc_auto_setup_eapd(struct hda_codec *codec, bool on)
 {
 	/* We currently only handle front, HP */
 	static hda_nid_t pins[] = {
-		0x0f, 0x10, 0x14, 0x15, 0
+		0x0f, 0x10, 0x14, 0x15, 0x17, 0
 	};
 	hda_nid_t *p;
 	for (p = pins; *p; p++)