| Message ID | 57da8293b865fb2d119e29073aec54323fc10000.1427736972.git.joe@perches.com |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
On Mon, 30 Mar 2015 10:43:21 -0700 Joe Perches <joe@perches.com> wrote: > Use the normal return values for bool functions > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/ssb/driver_gige.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c > index e973405..ebee6b0 100644 > --- a/drivers/ssb/driver_gige.c > +++ b/drivers/ssb/driver_gige.c > @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev, > bool pdev_is_ssb_gige_core(struct pci_dev *pdev) > { > if (!pdev->resource[0].name) > - return 0; > + return false; > return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0); > } > EXPORT_SYMBOL(pdev_is_ssb_gige_core); Looks good. Signed-off-by: Michael Buesch <m@bues.ch> Kalle, can you take this one, please?
Michael Büsch <m@bues.ch> writes: > On Mon, 30 Mar 2015 10:43:21 -0700 > Joe Perches <joe@perches.com> wrote: > >> Use the normal return values for bool functions >> >> Signed-off-by: Joe Perches <joe@perches.com> >> --- >> drivers/ssb/driver_gige.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c >> index e973405..ebee6b0 100644 >> --- a/drivers/ssb/driver_gige.c >> +++ b/drivers/ssb/driver_gige.c >> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev, >> bool pdev_is_ssb_gige_core(struct pci_dev *pdev) >> { >> if (!pdev->resource[0].name) >> - return 0; >> + return false; >> return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0); >> } >> EXPORT_SYMBOL(pdev_is_ssb_gige_core); > > Looks good. > > Signed-off-by: Michael Buesch <m@bues.ch> > > Kalle, can you take this one, please? Sure, I'll apply it in the next few days.
diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c index e973405..ebee6b0 100644 --- a/drivers/ssb/driver_gige.c +++ b/drivers/ssb/driver_gige.c @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev, bool pdev_is_ssb_gige_core(struct pci_dev *pdev) { if (!pdev->resource[0].name) - return 0; + return false; return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0); } EXPORT_SYMBOL(pdev_is_ssb_gige_core);
Use the normal return values for bool functions Signed-off-by: Joe Perches <joe@perches.com> --- drivers/ssb/driver_gige.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)