Patchwork qemu-img: Fix error message

login
register
mail settings
Submitter Kevin Wolf
Date Feb. 17, 2010, 11:33 a.m.
Message ID <1266406397-5121-1-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/45612/
State New
Headers show

Comments

Kevin Wolf - Feb. 17, 2010, 11:33 a.m.
When qemu-img can't open the new backing file for a rebase, it prints an error
message which contains the file name of the old backing file. This is wrong,
obviously.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-img.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Anthony Liguori - Feb. 19, 2010, 10:01 p.m.
On 02/17/2010 05:33 AM, Kevin Wolf wrote:
> When qemu-img can't open the new backing file for a rebase, it prints an error
> message which contains the file name of the old backing file. This is wrong,
> obviously.
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   qemu-img.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index b03b382..250d892 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1169,7 +1169,7 @@ static int img_rebase(int argc, char **argv)
>           if (bdrv_open2(bs_new_backing, out_baseimg, BRDV_O_FLAGS | BDRV_O_RDWR,
>               new_backing_drv))
>           {
> -            error("Could not open new backing file '%s'", backing_name);
> +            error("Could not open new backing file '%s'", out_baseimg);
>               return -1;
>           }
>       }
>

Patch

diff --git a/qemu-img.c b/qemu-img.c
index b03b382..250d892 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1169,7 +1169,7 @@  static int img_rebase(int argc, char **argv)
         if (bdrv_open2(bs_new_backing, out_baseimg, BRDV_O_FLAGS | BDRV_O_RDWR,
             new_backing_drv))
         {
-            error("Could not open new backing file '%s'", backing_name);
+            error("Could not open new backing file '%s'", out_baseimg);
             return -1;
         }
     }