| Message ID | 1427650429-9293-12-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2015-03-29 19:33 +0200, Thomas Petazzoni spake thusly: > In order to implement the global 'make source', 'make legal-info' and > 'make external-deps' using the package infrastructure logic, this > commit introduces a set of per-package targets that allow to > recursively run the source/legal-info/external-deps actions on the > dependencies of a given package. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > package/pkg-generic.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk > index 08e4cad..ba24591 100644 > --- a/package/pkg-generic.mk > +++ b/package/pkg-generic.mk > @@ -587,6 +587,12 @@ $(1)-graph-depends: graph-depends-requirements > |tee $$(O)/graphs/$$(@).dot \ > |dot $$(BR2_GRAPH_DOT_OPTS) -T$$(BR_GRAPH_OUT) -o $$(O)/graphs/$$(@).$$(BR_GRAPH_OUT) > > +$(1)-all-source: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-source) $(1)-source > + > +$(1)-all-external-deps: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-external-deps) $(1)-external-deps > + > +$(1)-all-legal-info: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-legal-info) $(1)-legal-info > + > $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN) > > $(1)-clean-for-reinstall: > -- > 2.1.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Thomas, All, On 2015-03-29 23:47 +0200, Yann E. MORIN spake thusly: > On 2015-03-29 19:33 +0200, Thomas Petazzoni spake thusly: > > In order to implement the global 'make source', 'make legal-info' and > > 'make external-deps' using the package infrastructure logic, this > > commit introduces a set of per-package targets that allow to > > recursively run the source/legal-info/external-deps actions on the > > dependencies of a given package. > > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Actually, I may have to withdraw that reviewed tag of mine... Testing patch 20/35 (Makefile: use <pkg>-all-legal-info to implement the legal-info target) does not give the same result as previously: - some packages that are not enabled get their legal-info "installed" - some non-existing or disabled host packages have their legal-info isntalled as well... Not sure this is due to theis patch 11/35, or really due to 20/35 (even though I have some clues as to incriminate patch 11...). I'll be investigating this a bit later... Regards, Yann E. MORIN. > Regards, > Yann E. MORIN. > > > --- > > package/pkg-generic.mk | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk > > index 08e4cad..ba24591 100644 > > --- a/package/pkg-generic.mk > > +++ b/package/pkg-generic.mk > > @@ -587,6 +587,12 @@ $(1)-graph-depends: graph-depends-requirements > > |tee $$(O)/graphs/$$(@).dot \ > > |dot $$(BR2_GRAPH_DOT_OPTS) -T$$(BR_GRAPH_OUT) -o $$(O)/graphs/$$(@).$$(BR_GRAPH_OUT) > > > > +$(1)-all-source: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-source) $(1)-source > > + > > +$(1)-all-external-deps: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-external-deps) $(1)-external-deps > > + > > +$(1)-all-legal-info: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-legal-info) $(1)-legal-info > > + > > $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN) > > > > $(1)-clean-for-reinstall: > > -- > > 2.1.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Yann E. MORIN, On Mon, 30 Mar 2015 19:45:12 +0200, Yann E. MORIN wrote: > Actually, I may have to withdraw that reviewed tag of mine... > > Testing patch 20/35 (Makefile: use <pkg>-all-legal-info to implement the > legal-info target) does not give the same result as previously: > > - some packages that are not enabled get their legal-info "installed" > - some non-existing or disabled host packages have their legal-info > isntalled as well... > > Not sure this is due to theis patch 11/35, or really due to 20/35 (even > though I have some clues as to incriminate patch 11...). > > I'll be investigating this a bit later... Can you give some specific example, i.e a defconfig that exhibits the problem? Thomas
Thomas, All, On 2015-03-30 19:45 +0200, Yann E. MORIN spake thusly: > On 2015-03-29 23:47 +0200, Yann E. MORIN spake thusly: > > On 2015-03-29 19:33 +0200, Thomas Petazzoni spake thusly: > > > In order to implement the global 'make source', 'make legal-info' and > > > 'make external-deps' using the package infrastructure logic, this > > > commit introduces a set of per-package targets that allow to > > > recursively run the source/legal-info/external-deps actions on the > > > dependencies of a given package. > > > > > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > > > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Actually, I may have to withdraw that reviewed tag of mine... > > Testing patch 20/35 (Makefile: use <pkg>-all-legal-info to implement the > legal-info target) does not give the same result as previously: > > - some packages that are not enabled get their legal-info "installed" > - some non-existing or disabled host packages have their legal-info > isntalled as well... > > Not sure this is due to theis patch 11/35, or really due to 20/35 (even > though I have some clues as to incriminate patch 11...). > > I'll be investigating this a bit later... Now for good: Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> That series just exposes some inconsistencies in the current state of affairs regarding legal-info in some packages. Most notably, as Thomas explained, host-packages legal-info was only at most two-lefvel deep, so we were missing parts of the host-packages legel-info, now exposed by this series. Also, some of our target packages have inconsistent depend/select in kconfig, that do not match the _DEPENDENCIES in their .mk file (and vice-versa), also exposed now. Regards, Yann E. MORIN.
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 08e4cad..ba24591 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -587,6 +587,12 @@ $(1)-graph-depends: graph-depends-requirements |tee $$(O)/graphs/$$(@).dot \ |dot $$(BR2_GRAPH_DOT_OPTS) -T$$(BR_GRAPH_OUT) -o $$(O)/graphs/$$(@).$$(BR_GRAPH_OUT) +$(1)-all-source: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-source) $(1)-source + +$(1)-all-external-deps: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-external-deps) $(1)-external-deps + +$(1)-all-legal-info: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-legal-info) $(1)-legal-info + $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN) $(1)-clean-for-reinstall:
In order to implement the global 'make source', 'make legal-info' and 'make external-deps' using the package infrastructure logic, this commit introduces a set of per-package targets that allow to recursively run the source/legal-info/external-deps actions on the dependencies of a given package. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/pkg-generic.mk | 6 ++++++ 1 file changed, 6 insertions(+)