diff mbox

NPTL: Fix wrong comments for THREAD_SETMEM and THREAD_SETMEM_NC for i386 and x86_64.

Message ID 1427517116-7911-1-git-send-email-martin.galvan@tallertechnologies.com
State New
Headers show

Commit Message

Martin Galvan March 28, 2015, 4:31 a.m. UTC 
2015-03-28  Martin Galvan  <martin.galvan@tallertechnologies.com>

The comments for THREAD_SETMEM and THREAD_SETMEM_NC were swapped for i386 and x86_64; this patch fixes that.

I don't have a copyright assignment yet, but since this is a minor change I don't think it's necessary.

ChangeLog:

	* sysdeps/i386/nptl/tls.h: Swapped comments between THREAD_SETMEM and
	THREAD_SETMEM_NC.
	* sysdeps/x86_64/nptl/tls.h: Ditto.

---
 sysdeps/i386/nptl/tls.h   | 5 +++--
 sysdeps/x86_64/nptl/tls.h | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

--
2.3.4

Comments

Mike Frysinger March 28, 2015, 4:45 a.m. UTC | #1 
On 28 Mar 2015 01:31, Martin Galvan wrote:
> 2015-03-28  Martin Galvan  <martin.galvan@tallertechnologies.com>
> 
> The comments for THREAD_SETMEM and THREAD_SETMEM_NC were swapped for i386 and x86_64; this patch fixes that.
> 
> I don't have a copyright assignment yet, but since this is a minor change I don't think it's necessary.

agreed; pushed; thanks!
-mike
diff mbox

Patch

diff --git a/sysdeps/i386/nptl/tls.h b/sysdeps/i386/nptl/tls.h
index 40f84ef..829cd3a 100644
--- a/sysdeps/i386/nptl/tls.h
+++ b/sysdeps/i386/nptl/tls.h
@@ -316,7 +316,8 @@  tls_fill_user_desc (union user_desc_init *desc,
      __value; })


-/* Same as THREAD_SETMEM, but the member offset can be non-constant.  */
+
+/* Set member of the thread descriptor directly.  */
 # define THREAD_SETMEM(descr, member, value) \
   ({ if (sizeof (descr->member) == 1)					      \
        asm volatile ("movb %b0,%%gs:%P1" :				      \
@@ -341,7 +342,7 @@  tls_fill_user_desc (union user_desc_init *desc,
        }})


-/* Set member of the thread descriptor directly.  */
+/* Same as THREAD_SETMEM, but the member offset can be non-constant.  */
 # define THREAD_SETMEM_NC(descr, member, idx, value) \
   ({ if (sizeof (descr->member[0]) == 1)				      \
        asm volatile ("movb %b0,%%gs:%P1(%2)" :				      \
diff --git a/sysdeps/x86_64/nptl/tls.h b/sysdeps/x86_64/nptl/tls.h
index b947d57..d7543c6 100644
--- a/sysdeps/x86_64/nptl/tls.h
+++ b/sysdeps/x86_64/nptl/tls.h
@@ -250,7 +250,7 @@  typedef struct
 #endif


-/* Same as THREAD_SETMEM, but the member offset can be non-constant.  */
+/* Set member of the thread descriptor directly.  */
 # define THREAD_SETMEM(descr, member, value) \
   ({ if (sizeof (descr->member) == 1)					      \
        asm volatile ("movb %b0,%%fs:%P1" :				      \
@@ -273,7 +273,7 @@  typedef struct
        }})


-/* Set member of the thread descriptor directly.  */
+/* Same as THREAD_SETMEM, but the member offset can be non-constant.  */
 # define THREAD_SETMEM_NC(descr, member, idx, value) \
   ({ if (sizeof (descr->member[0]) == 1)				      \
        asm volatile ("movb %b0,%%fs:%P1(%q2)" :				      \