Patchwork [LUCID,1/3] request-pull suspend/resume report

login
register
mail settings
Submitter Manoj Iyer
Date Feb. 16, 2010, 7:48 p.m.
Message ID <alpine.DEB.2.00.1002161347120.18301@hungry>
Download mbox | patch
Permalink /patch/45557/
State Accepted
Delegated to: Andy Whitcroft
Headers show

Comments

Manoj Iyer - Feb. 16, 2010, 7:48 p.m.
Resending patch, incorporated review comments

The following changes since commit 
4b876bd4ad82fb8866fcf8724514c80ebc158f1d:
   Andy Whitcroft (1):
         UBUNTU: ensure we build the source package contents when enabled

are available in the git repository at:


ssh://zinc.canonical.com/srv/kernel.ubuntu.com/git/manjo/ubuntu-lucid.git 
pmsrtime

Manoj Iyer (2):
       UBUNTU: SAUCE: PM report driver and device suspend/resume times.
       UBUNTU: [Config] added new config option CONFIG_SR_REPORT_TIME_LIMIT

Rafael J. Wysocki (1):
       PM: Measure device suspend and resume times

  debian.master/config/config.common.ubuntu |    1 +
  drivers/Kconfig                           |    2 ++
  drivers/base/power/Kconfig                |    6 ++++++
  drivers/base/power/main.c                 |   26 
++++++++++++++++++++++++++
  4 files changed, 35 insertions(+), 0 deletions(-)
  create mode 100644 drivers/base/power/Kconfig
From 1e856754941e93f470014be0470d8af9f782f470 Mon Sep 17 00:00:00 2001
From: Rafael J. Wysocki <rjw@sisk.pl>
Date: Fri, 18 Dec 2009 01:57:47 +0100
Subject: [PATCH 1/3] PM: Measure device suspend and resume times

Measure and print the time of suspending and resuming all devices.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
(cherry picked from commit ecf762b2581e12ac761d12a6e4e297c2224aa899)

Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
  drivers/base/power/main.c |   27 +++++++++++++++++++++++++++
  1 files changed, 27 insertions(+), 0 deletions(-)

Patch

diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 8aa2443..d72d4b3 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -324,6 +324,23 @@  static void pm_dev_err(struct device *dev, pm_message_t state, char *info,
  		kobject_name(&dev->kobj), pm_verb(state.event), info, error);
  }

+static void dpm_show_time(ktime_t starttime, pm_message_t state, char *info)
+{
+	ktime_t calltime;
+	s64 usecs64;
+	int usecs;
+
+	calltime = ktime_get();
+	usecs64 = ktime_to_ns(ktime_sub(calltime, starttime));
+	do_div(usecs64, NSEC_PER_USEC);
+	usecs = usecs64;
+	if (usecs == 0)
+		usecs = 1;
+	pr_info("PM: %s%s%s of devices complete after %ld.%03ld msecs\n",
+		info ?: "", info ? " " : "", pm_verb(state.event),
+		usecs / USEC_PER_MSEC, usecs % USEC_PER_MSEC);
+}
+
  /*------------------------- Resume routines -------------------------*/

  /**
@@ -363,6 +380,7 @@  static int device_resume_noirq(struct device *dev, pm_message_t state)
  void dpm_resume_noirq(pm_message_t state)
  {
  	struct device *dev;
+	ktime_t starttime = ktime_get();

  	mutex_lock(&dpm_list_mtx);
  	transition_started = false;
@@ -376,6 +394,7 @@  void dpm_resume_noirq(pm_message_t state)
  				pm_dev_err(dev, state, " early", error);
  		}
  	mutex_unlock(&dpm_list_mtx);
+	dpm_show_time(starttime, state, "early");
  	resume_device_irqs();
  }
  EXPORT_SYMBOL_GPL(dpm_resume_noirq);
@@ -441,6 +460,7 @@  static int device_resume(struct device *dev, pm_message_t state)
  static void dpm_resume(pm_message_t state)
  {
  	struct list_head list;
+	ktime_t starttime = ktime_get();

  	INIT_LIST_HEAD(&list);
  	mutex_lock(&dpm_list_mtx);
@@ -469,6 +489,7 @@  static void dpm_resume(pm_message_t state)
  	}
  	list_splice(&list, &dpm_list);
  	mutex_unlock(&dpm_list_mtx);
+	dpm_show_time(starttime, state, NULL);
  }

  /**
@@ -604,6 +625,7 @@  static int device_suspend_noirq(struct device *dev, pm_message_t state)
  int dpm_suspend_noirq(pm_message_t state)
  {
  	struct device *dev;
+	ktime_t starttime = ktime_get();
  	int error = 0;

  	suspend_device_irqs();
@@ -619,6 +641,8 @@  int dpm_suspend_noirq(pm_message_t state)
  	mutex_unlock(&dpm_list_mtx);
  	if (error)
  		dpm_resume_noirq(resume_event(state));
+	else
+		dpm_show_time(starttime, state, "late");
  	return error;
  }
  EXPORT_SYMBOL_GPL(dpm_suspend_noirq);
@@ -679,6 +703,7 @@  static int device_suspend(struct device *dev, pm_message_t state)
  static int dpm_suspend(pm_message_t state)
  {
  	struct list_head list;
+	ktime_t starttime = ktime_get();
  	int error = 0;

  	INIT_LIST_HEAD(&list);
@@ -704,6 +729,8 @@  static int dpm_suspend(pm_message_t state)
  	}
  	list_splice(&list, dpm_list.prev);
  	mutex_unlock(&dpm_list_mtx);
+	if (!error)
+		dpm_show_time(starttime, state, NULL);
  	return error;
  }