| Message ID | 5514A013.7040300@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Hans de Goede |
| Headers | show |
On Fri, 2015-03-27 at 00:10 +0000, Iain Paton wrote: > clock divisors table was missing an entry for 912MHz. The same table is > used for sun7i where the default boot clock is 912MHz, resulting in A20 > boards being overclocked to 960MHz Apart from the missing entry, should it not be the case that we pick the highest frequency <= than the requested frequency, rather than the next available (potentially higher) frequency? IOW I'd expect things to be underclocked at 768MHz without this change, which would mean that clock_set_pll1 is buggy. Ian. > > Signed-off-by: Iain Paton <ipaton0@gmail.com> > --- > arch/arm/cpu/armv7/sunxi/clock_sun4i.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/cpu/armv7/sunxi/clock_sun4i.c b/arch/arm/cpu/armv7/sunxi/clock_sun4i.c > index 49f4032..c720e96 100644 > --- a/arch/arm/cpu/armv7/sunxi/clock_sun4i.c > +++ b/arch/arm/cpu/armv7/sunxi/clock_sun4i.c > @@ -102,6 +102,7 @@ static struct { > /* This array must be ordered by frequency. */ > { PLL1_CFG(16, 0, 0, 0), 384000000 }, > { PLL1_CFG(16, 1, 0, 0), 768000000 }, > + { PLL1_CFG(19, 1, 0, 0), 912000000 }, > { PLL1_CFG(20, 1, 0, 0), 960000000 }, > { PLL1_CFG(21, 1, 0, 0), 1008000000}, > { PLL1_CFG(22, 1, 0, 0), 1056000000},
On 27/03/15 14:04, Ian Campbell wrote: > On Fri, 2015-03-27 at 00:10 +0000, Iain Paton wrote: >> clock divisors table was missing an entry for 912MHz. The same table is >> used for sun7i where the default boot clock is 912MHz, resulting in A20 >> boards being overclocked to 960MHz > > Apart from the missing entry, should it not be the case that we pick the > highest frequency <= than the requested frequency, rather than the next > available (potentially higher) frequency? > > IOW I'd expect things to be underclocked at 768MHz without this change, > which would mean that clock_set_pll1 is buggy. Perhaps, however the selection algorithm is so trivial that I have difficulty beleiving that picking next highest was anything other than deliberate and the intended outcome. I'll send a revised version that changes it to next lowest. Rgds, Iain
diff --git a/arch/arm/cpu/armv7/sunxi/clock_sun4i.c b/arch/arm/cpu/armv7/sunxi/clock_sun4i.c index 49f4032..c720e96 100644 --- a/arch/arm/cpu/armv7/sunxi/clock_sun4i.c +++ b/arch/arm/cpu/armv7/sunxi/clock_sun4i.c @@ -102,6 +102,7 @@ static struct { /* This array must be ordered by frequency. */ { PLL1_CFG(16, 0, 0, 0), 384000000 }, { PLL1_CFG(16, 1, 0, 0), 768000000 }, + { PLL1_CFG(19, 1, 0, 0), 912000000 }, { PLL1_CFG(20, 1, 0, 0), 960000000 }, { PLL1_CFG(21, 1, 0, 0), 1008000000}, { PLL1_CFG(22, 1, 0, 0), 1056000000},
clock divisors table was missing an entry for 912MHz. The same table is used for sun7i where the default boot clock is 912MHz, resulting in A20 boards being overclocked to 960MHz Signed-off-by: Iain Paton <ipaton0@gmail.com> --- arch/arm/cpu/armv7/sunxi/clock_sun4i.c | 1 + 1 file changed, 1 insertion(+)