Patchwork [net-2.6] be2net: set proper value to version field in req hdr

login
register
mail settings
Submitter Ajit Khaparde
Date Feb. 16, 2010, 10:18 a.m.
Message ID <20100216101749.GA9465@serverengines.com>
Download mbox | patch
Permalink /patch/45458/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ajit Khaparde - Feb. 16, 2010, 10:18 a.m.
Before sending a command to the ASIC, set version properly.
This is necessary for the ARM firmware to send correct data to the driver.
This also fixes a bug in certain skews of the ASIC where the statistics
are misreported.

Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
---
 drivers/net/benet/be_cmds.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
David Miller - Feb. 16, 2010, 11:15 p.m.
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 16 Feb 2010 15:48:46 +0530

> Before sending a command to the ASIC, set version properly.
> This is necessary for the ARM firmware to send correct data to the driver.
> This also fixes a bug in certain skews of the ASIC where the statistics
> are misreported.
> 
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index fee6eee..006cb2e 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -296,6 +296,7 @@  static void be_cmd_hdr_prepare(struct be_cmd_req_hdr *req_hdr,
 	req_hdr->opcode = opcode;
 	req_hdr->subsystem = subsystem;
 	req_hdr->request_length = cpu_to_le32(cmd_len - sizeof(*req_hdr));
+	req_hdr->version = 0;
 }
 
 static void be_cmd_page_addrs_prepare(struct phys_addr *pages, u32 max_pages,