diff mbox

nft-test: don't use colors if output is not a tty

Message ID 1427268710-2889-1-git-send-email-kaber@trash.net
State Accepted
Delegated to: Pablo Neira
Headers show

Commit Message

Patrick McHardy March 25, 2015, 7:31 a.m. UTC 
Signed-off-by: Patrick McHardy <kaber@trash.net>
---
 tests/regression/nft-test.py | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

Comments

Jan Engelhardt March 25, 2015, 8:27 a.m. UTC | #1 
>+    if sys.stdout.isatty():
>+        HEADER = '\033[95m'
>+        GREEN = '\033[92m'
>+        YELLOW = '\033[93m'
>+        RED = '\033[91m'
>+        ENDC = '\033[0m'

Where did the values 91, 92, 93, 95 actually come from? They are 
nonstandard and, apparently, are a carry-over for AIX compatibility.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/tests/regression/nft-test.py b/tests/regression/nft-test.py
index 2677127..559ad41 100755
--- a/tests/regression/nft-test.py
+++ b/tests/regression/nft-test.py
@@ -31,12 +31,18 @@  signal_received = 0
 
 
 class Colors:
-    HEADER = '\033[95m'
-    GREEN = '\033[92m'
-    YELLOW = '\033[93m'
-    RED = '\033[91m'
-    ENDC = '\033[0m'
-
+    if sys.stdout.isatty():
+        HEADER = '\033[95m'
+        GREEN = '\033[92m'
+        YELLOW = '\033[93m'
+        RED = '\033[91m'
+        ENDC = '\033[0m'
+    else:
+        HEADER = ''
+        GREEN = ''
+        YELLOW = ''
+        RED = ''
+        ENDC = ''
 
 def print_error(reason, filename=None, lineno=None):
     '''