| Message ID | 1427260392-4186-1-git-send-email-jh80.chung@samsung.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Mar 25, 2015 at 05:13:12AM +0000, Jaehoon Chung wrote: > There is the sentence error. > Changed the semicolon instead of comma. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/pci/host/pci-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c > index d202b37..c139237 100644 > --- a/drivers/pci/host/pci-exynos.c > +++ b/drivers/pci/host/pci-exynos.c > @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp) > > /* enable INTX interrupt */ > val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT | > - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT, > + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT; > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE); > } Well spotted. The original change dates from July 2013, I'm guessing no one uses PCIe on Exynos? Best regards, Liviu > > -- > 1.9.1 > >
Dear, Liviu. On 03/25/2015 06:44 PM, Liviu Dudau wrote: > On Wed, Mar 25, 2015 at 05:13:12AM +0000, Jaehoon Chung wrote: >> There is the sentence error. >> Changed the semicolon instead of comma. >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> drivers/pci/host/pci-exynos.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c >> index d202b37..c139237 100644 >> --- a/drivers/pci/host/pci-exynos.c >> +++ b/drivers/pci/host/pci-exynos.c >> @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp) >> >> /* enable INTX interrupt */ >> val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT | >> - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT, >> + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT; >> exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE); >> } > > Well spotted. The original change dates from July 2013, I'm guessing no one uses > PCIe on Exynos? pci-exynos.c based on Exynos5440. I can't also see whoever use it. But exynos5433 is used the PCIe. There is difference between exynos5440 and exynos5433. (i.e. Register base and offset..) If exynos5440 is not used, i want to update pci-exynos.c to base on exynos5433. In future, exynos should be use the PCIe... ASAP, I will send the patch-set for exynos5433. Before sending patch-set, just sent the patch for fixing it. (Also, working on supporting ARM64 at pcie-designware.c) Best Regards, Jaehoon Chung > > Best regards, > Liviu > >> >> -- >> 1.9.1 >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 25, 2015 at 02:13:12PM +0900, Jaehoon Chung wrote: > There is the sentence error. > Changed the semicolon instead of comma. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to pci/host-exynos for v4.1. Jingoo, speak up if you object, but this looks like a pretty obvious error. > --- > drivers/pci/host/pci-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c > index d202b37..c139237 100644 > --- a/drivers/pci/host/pci-exynos.c > +++ b/drivers/pci/host/pci-exynos.c > @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp) > > /* enable INTX interrupt */ > val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT | > - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT, > + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT; > exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE); > } > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c index d202b37..c139237 100644 --- a/drivers/pci/host/pci-exynos.c +++ b/drivers/pci/host/pci-exynos.c @@ -396,7 +396,7 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp) /* enable INTX interrupt */ val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT | - IRQ_INTC_ASSERT | IRQ_INTD_ASSERT, + IRQ_INTC_ASSERT | IRQ_INTD_ASSERT; exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE); }
There is the sentence error. Changed the semicolon instead of comma. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/pci/host/pci-exynos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)