Patchwork [iproute2] : skbedit: use get_u32 for parsing mark

login
register
mail settings
Submitter jamal
Date Feb. 15, 2010, 11:51 a.m.
Message ID <1266234661.6776.82.camel@bigi>
Download mbox | patch
Permalink /patch/45355/
State Accepted
Delegated to: stephen hemminger
Headers show

Comments

jamal - Feb. 15, 2010, 11:51 a.m.
parsing a mark as a classid allows for acceptance of strange
informal input.

cheers,
jamal
commit aad0da6507ff8a95a63ed8e529c05f52be5b0e75
Author: Jamal Hadi Salim <hadi@cyberus.ca>
Date:   Mon Feb 15 06:45:29 2010 -0500

    skbedit: use get_u32 for parsing mark
    
    get_u32 is the more appropriate parser for a mark.
    
    Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>

Patch

diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 5d1a96a..990b9c7 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -86,7 +86,7 @@  parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
 		} else if (matches(*argv, "mark") == 0) {
 			flags |= SKBEDIT_F_MARK;
 			NEXT_ARG();
-			if (get_tc_classid(&mark, *argv)) {
+			if (get_u32(&mark, *argv, 0)) {
 				fprintf(stderr, "Illegal mark\n");
 				return -1;
 			}