Patchwork pcnet APROMWE bit location

login
register
mail settings
Submitter Chris Kilgour
Date Feb. 15, 2010, 1:53 a.m.
Message ID <4B78A904.9020700@whiterocker.com>
Download mbox | patch
Permalink /patch/45343/
State New
Headers show

Comments

Chris Kilgour - Feb. 15, 2010, 1:53 a.m.
I don't subscribe to the list, so please excuse any breach of etiquette. 

According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.

Signed-off-by: Christopher Kilgour <techie <at> whiterocker.com>
---
Anthony Liguori - Feb. 19, 2010, 9:33 p.m.
On 02/14/2010 07:53 PM, Chris Kilgour wrote:
> I don't subscribe to the list, so please excuse any breach of etiquette.
>
> According to AMD document 21485D pp.141, APROMWE is bit 8 of BCR2.
>
> Signed-off-by: Christopher Kilgour<techie<at>  whiterocker.com>
>    

Your mailer munged this patch so it doesn't apply.  Please resend.  
Also, please use a proper email address in the Signed-off-by line.

Regards,

Anthony Liguori

> ---
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index 44b5b31..f889898 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1601,7 +1601,7 @@ static void pcnet_aprom_writeb(void *opaque,
> uint32_t addr
>       printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
>   #endif
>       /* Check APROMWE bit to enable write access */
> -    if (pcnet_bcr_readw(s,2)&  0x80)
> +    if (pcnet_bcr_readw(s,2)&  0x100)
>           s->prom[addr&  15] = val;
>   }
>
>
>
>
>

Patch

diff --git a/hw/pcnet.c b/hw/pcnet.c
index 44b5b31..f889898 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1601,7 +1601,7 @@  static void pcnet_aprom_writeb(void *opaque,
uint32_t addr
     printf("pcnet_aprom_writeb addr=0x%08x val=0x%02x\n", addr, val);
 #endif
     /* Check APROMWE bit to enable write access */
-    if (pcnet_bcr_readw(s,2) & 0x80)
+    if (pcnet_bcr_readw(s,2) & 0x100)
         s->prom[addr & 15] = val;
 }