| Message ID | 1426916361-18328-1-git-send-email-maheshb@google.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 3/21/2015 8:39 AM, Mahesh Bandewar wrote: > RTNL is required for sending notifications and if rtnl can not be > acquired, current code skips sending notification. This is especially > bad if the monitoring values selected are large. > This patch adds a bitmask and uses a bit per such work-queue and attempts > to reschedule the work (aggressively) until notifications are sent out and > then resumes the regular cycle. > Signed-off-by: Mahesh Bandewar <maheshb@google.com> > --- > include/net/bonding.h | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > diff --git a/include/net/bonding.h b/include/net/bonding.h > index 0ac45b4f7f2a..fede3ab4bbcf 100644 > --- a/include/net/bonding.h > +++ b/include/net/bonding.h [...] > @@ -259,6 +260,24 @@ struct bond_vlan_tag { > unsigned short vlan_id; > }; > > +typedef enum { > + BOND_MII_NOTIF = 0, > + BOND_ARP_NOTIF, > + BOND_AD_NOTIF, > +} bond_notif_pending_t; > + > +static inline bool bond_get_notif_pending(struct bonding *bond, > + bond_notif_pending_t bit) > +{ > + return !!test_and_clear_bit(bit, &bond->notif_work_mask); > +} > + > +static inline void bond_set_notif_pending(struct bonding *bond, > + bond_notif_pending_t bit) > +{ > + set_bit(bit, &bond->notif_work_mask); One tab to many here. :-) > +} > + > /** > * Returns NULL if the net_device does not belong to any of the bond's slaves > * WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/bonding.h b/include/net/bonding.h index 0ac45b4f7f2a..fede3ab4bbcf 100644 --- a/include/net/bonding.h +++ b/include/net/bonding.h @@ -239,6 +239,7 @@ struct bonding { struct delayed_work ad_work; struct delayed_work mcast_work; struct delayed_work slave_arr_work; + unsigned long notif_work_mask; #ifdef CONFIG_DEBUG_FS /* debugging support via debugfs */ struct dentry *debug_dir; @@ -259,6 +260,24 @@ struct bond_vlan_tag { unsigned short vlan_id; }; +typedef enum { + BOND_MII_NOTIF = 0, + BOND_ARP_NOTIF, + BOND_AD_NOTIF, +} bond_notif_pending_t; + +static inline bool bond_get_notif_pending(struct bonding *bond, + bond_notif_pending_t bit) +{ + return !!test_and_clear_bit(bit, &bond->notif_work_mask); +} + +static inline void bond_set_notif_pending(struct bonding *bond, + bond_notif_pending_t bit) +{ + set_bit(bit, &bond->notif_work_mask); +} + /** * Returns NULL if the net_device does not belong to any of the bond's slaves *
RTNL is required for sending notifications and if rtnl can not be acquired, current code skips sending notification. This is especially bad if the monitoring values selected are large. This patch adds a bitmask and uses a bit per such work-queue and attempts to reschedule the work (aggressively) until notifications are sent out and then resumes the regular cycle. Signed-off-by: Mahesh Bandewar <maheshb@google.com> --- include/net/bonding.h | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)