diff mbox

[v2,04/25] psplash: move systemd service files to /usr/lib

Message ID 1426878856-15747-5-git-send-email-mike@mikebwilliams.com
State Superseded
Headers show

Commit Message

Mike Williams March 20, 2015, 7:13 p.m. UTC
Signed-off-by: Mike Williams <mike@mikebwilliams.com>
---
 package/psplash/psplash.mk | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Thomas Petazzoni March 20, 2015, 7:36 p.m. UTC | #1
Dear Mike Williams,

On Fri, 20 Mar 2015 15:13:55 -0400, Mike Williams wrote:

>  define PSPLASH_INSTALL_INIT_SYSTEMD
> +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> +
>  	$(INSTALL) -D -m 644 package/psplash/psplash-start.service \
> -		$(TARGET_DIR)/etc/systemd/system/psplash-start.service
> -	$(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants
> -	ln -sf  ../psplash-start.service \
> +		$(TARGET_DIR)/usr/lib/systemd/system/psplash-start.service
> +	$(INSTALL) -d $(TARGET_DIR)/usr/lib/systemd/system/sysinit.target.wants

Why are we creating this directory?

Thanks,

Thomas
Thomas Petazzoni April 9, 2015, 7:57 p.m. UTC | #2
Mike,

Ping ?

Thomas

On Fri, 20 Mar 2015 20:36:11 +0100, Thomas Petazzoni wrote:
> Dear Mike Williams,
> 
> On Fri, 20 Mar 2015 15:13:55 -0400, Mike Williams wrote:
> 
> >  define PSPLASH_INSTALL_INIT_SYSTEMD
> > +	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> > +
> >  	$(INSTALL) -D -m 644 package/psplash/psplash-start.service \
> > -		$(TARGET_DIR)/etc/systemd/system/psplash-start.service
> > -	$(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants
> > -	ln -sf  ../psplash-start.service \
> > +		$(TARGET_DIR)/usr/lib/systemd/system/psplash-start.service
> > +	$(INSTALL) -d $(TARGET_DIR)/usr/lib/systemd/system/sysinit.target.wants
> 
> Why are we creating this directory?
> 
> Thanks,
> 
> Thomas
Mike Williams April 10, 2015, 1:49 p.m. UTC | #3
Thomas,

I'll take a look at all of those patches with comments next week, I'm
working on another project for a bit.

Thanks,
Mike

On Thu, Apr 9, 2015 at 3:57 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Mike,
>
> Ping ?
>
> Thomas
>
> On Fri, 20 Mar 2015 20:36:11 +0100, Thomas Petazzoni wrote:
>> Dear Mike Williams,
>>
>> On Fri, 20 Mar 2015 15:13:55 -0400, Mike Williams wrote:
>>
>> >  define PSPLASH_INSTALL_INIT_SYSTEMD
>> > +   mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
>> > +
>> >     $(INSTALL) -D -m 644 package/psplash/psplash-start.service \
>> > -           $(TARGET_DIR)/etc/systemd/system/psplash-start.service
>> > -   $(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants
>> > -   ln -sf  ../psplash-start.service \
>> > +           $(TARGET_DIR)/usr/lib/systemd/system/psplash-start.service
>> > +   $(INSTALL) -d $(TARGET_DIR)/usr/lib/systemd/system/sysinit.target.wants
>>
>> Why are we creating this directory?
>>
>> Thanks,
>>
>> Thomas
>
>
>
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
diff mbox

Patch

diff --git a/package/psplash/psplash.mk b/package/psplash/psplash.mk
index 5901547..0e78c8c 100644
--- a/package/psplash/psplash.mk
+++ b/package/psplash/psplash.mk
@@ -10,16 +10,18 @@  PSPLASH_LICENSE = GPLv2+
 PSPLASH_AUTORECONF = YES
 
 define PSPLASH_INSTALL_INIT_SYSTEMD
+	mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
+
 	$(INSTALL) -D -m 644 package/psplash/psplash-start.service \
-		$(TARGET_DIR)/etc/systemd/system/psplash-start.service
-	$(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants
-	ln -sf  ../psplash-start.service \
+		$(TARGET_DIR)/usr/lib/systemd/system/psplash-start.service
+	$(INSTALL) -d $(TARGET_DIR)/usr/lib/systemd/system/sysinit.target.wants
+	ln -sf  ../../../../usr/lib/systemd/system/psplash-start.service \
 		 $(TARGET_DIR)/etc/systemd/system/sysinit.target.wants/
 
 	$(INSTALL) -D -m 644 package/psplash/psplash-quit.service \
-		$(TARGET_DIR)/etc/systemd/system/psplash-quit.service
+		$(TARGET_DIR)/usr/lib/systemd/system/psplash-quit.service
 	$(INSTALL) -d $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
-	ln -sf  ../psplash-quit.service \
+	ln -sf  ../../../../usr/lib/systemd/system/psplash-quit.service \
 		 $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/
 endef