[debug-early] minor cleanups
diff mbox

Message ID 550C5033.4040903@redhat.com
State New
Headers show

Commit Message

Aldy Hernandez March 20, 2015, 4:52 p.m. UTC
Just cleaning up some left over or non-applicable comments.

Committed to branch.
commit b783ed568b4b56d42f4203ce32d964104be6a368
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Fri Mar 20 09:49:23 2015 -0700

    Minor cleanups.

Patch
diff mbox

diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c
index c538d2e..c4ffcf2 100644
--- a/gcc/c/c-decl.c
+++ b/gcc/c/c-decl.c
@@ -10675,13 +10675,8 @@  c_write_global_declarations_1 (tree globals)
     }
   while (reconsider);
 
-  /* ?? For completeness, we could stop the TV_PHASE_DEFERRED timer
-     here, and start the TV_PHASE_DBGINFO timer.  Is it worth it, or
-     would it convolute things?  */
   for (decl = globals; decl; decl = DECL_CHAIN (decl))
     check_global_declaration_1 (decl);
-  /* ?? Similarly here. Stop TV_PHASE_DBGINFO and start
-     TV_PHASE_DEFERRED again.  */
 }
 
 /* Callback to collect a source_ref from a DECL.  */
diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index 76fd70b..48bd5b8 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -18040,9 +18040,7 @@  gen_formal_parameter_die (tree node, tree origin, bool emit_name_p,
 	{
 	  /* Check that parm_die already has the right attributes that
 	     we would have added below.  If any attributes are
-	     missing, fall through to add them.
-
-	     ?? Add more checks here.  */
+	     missing, fall through to add them.  */
 	  if (! DECL_ABSTRACT_P (node_or_origin)
 	      && !get_AT (parm_die, DW_AT_location)
 	      && !get_AT (parm_die, DW_AT_const_value))
diff --git a/gcc/go/go-gcc.cc b/gcc/go/go-gcc.cc
index 42cced4..7965b11 100644
--- a/gcc/go/go-gcc.cc
+++ b/gcc/go/go-gcc.cc
@@ -3084,12 +3084,6 @@  Gcc_backend::write_global_definitions(
 
   wrapup_global_declarations(defs, i);
 
-  /* ?? Can we leave this call here, thus getting called before
-     finalize_compilation_unit?
-
-     Originally this was called *AFTER* finalize_compilation_unit.  If
-     `go' really needs this call after finalize_compilation_unit, we
-     can use LANG_HOOKS_POST_COMPILATION_PARSING_CLEANUPS (yuck).  */
   check_global_declarations(defs, i);
 
   delete[] defs;
diff --git a/gcc/tree.c b/gcc/tree.c
index 06d30e8..97b9170 100644
--- a/gcc/tree.c
+++ b/gcc/tree.c
@@ -5257,8 +5257,6 @@  free_lang_data_in_decl (tree decl)
 	 At this point, it is not needed anymore.  */
       DECL_SAVED_TREE (decl) = NULL_TREE;
 
-      /* ?? This should be OK to remove now that we are generating dwarf
-	 early.  */
       /* Clear the abstract origin if it refers to a method.  Otherwise
          dwarf2out.c will ICE as we clear TYPE_METHODS and thus the
 	 origin will not be output correctly.  */