| Message ID | 1426858337-21423-1-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
Forgot to stick for-2.3 into the subject.
On 03/20/2015 07:32 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qapi/block-core.json | 4 ++++ > qmp-commands.hx | 4 ++++ > 2 files changed, 8 insertions(+) Never hurts to document things like this, even after freeze :) Reviewed-by: Eric Blake <eblake@redhat.com>
On Fri, Mar 20, 2015 at 02:32:17PM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > qapi/block-core.json | 4 ++++ > qmp-commands.hx | 4 ++++ > 2 files changed, 8 insertions(+) Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
diff --git a/qapi/block-core.json b/qapi/block-core.json index f525b04..7873084 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1721,6 +1721,10 @@ # # Creates a new block device. # +# This command is still a work in progress. It doesn't support all +# block drivers, it lacks a matching blockdev-del, and more. Stay +# away from it unless you want to help with its development. +# # @options: block device options for the new device # # Since: 1.7 diff --git a/qmp-commands.hx b/qmp-commands.hx index 7f68760..3a42ad0 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -3636,6 +3636,10 @@ blockdev-add Add a block device. +This command is still a work in progress. It doesn't support all +block drivers, it lacks a matching blockdev-del, and more. Stay away +from it unless you want to help with its development. + Arguments: - "options": block driver options
Signed-off-by: Markus Armbruster <armbru@redhat.com> --- qapi/block-core.json | 4 ++++ qmp-commands.hx | 4 ++++ 2 files changed, 8 insertions(+)