diff mbox

[U-Boot,6/6] ARM: tegra: Make pinmux.h standalone includible

Message ID 1426854262-1248-6-git-send-email-thierry.reding@gmail.com
State Accepted
Delegated to: Tom Warren
Headers show

Commit Message

Thierry Reding March 20, 2015, 12:24 p.m. UTC 
From: Thierry Reding <treding@nvidia.com>

This header file uses type definitions (u8, u32) from linux/types.h but
doesn't include it. If includes aren't carefully ordered this can cause
build failures.

Cc: Tom Warren <twarren@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 arch/arm/include/asm/arch-tegra/pinmux.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stephen Warren March 20, 2015, 4:30 p.m. UTC | #1 
On 03/20/2015 06:24 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This header file uses type definitions (u8, u32) from linux/types.h but
> doesn't include it. If includes aren't carefully ordered this can cause
> build failures.

I think patches 3-6 look fine, so they're,
Acked-by: Stephen Warren <swarren@nvidia.com>
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-tegra/pinmux.h b/arch/arm/include/asm/arch-tegra/pinmux.h
index 4212e5769930..9384985259db 100644
--- a/arch/arm/include/asm/arch-tegra/pinmux.h
+++ b/arch/arm/include/asm/arch-tegra/pinmux.h
@@ -8,6 +8,8 @@ 
 #ifndef _TEGRA_PINMUX_H_
 #define _TEGRA_PINMUX_H_
 
+#include <linux/types.h>
+
 #include <asm/arch/tegra.h>
 
 /* The pullup/pulldown state of a pin group */