diff mbox

[U-Boot,10/13] usb: mass-storage: Build warning fixes for 64-bit

Message ID 1426851688-6429-10-git-send-email-thierry.reding@gmail.com
State Accepted
Delegated to: Marek Vasut
Headers show

Commit Message

Thierry Reding March 20, 2015, 11:41 a.m. UTC 
From: Thierry Reding <treding@nvidia.com>

Fix a printf format mismatch warning seen on 64-bit builds.

Cc: Łukasz Majewski <l.majewski@samsung.com>
Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/usb/gadget/f_mass_storage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Łukasz Majewski March 23, 2015, 10:20 a.m. UTC | #1 
Hi Thierry,

> From: Thierry Reding <treding@nvidia.com>
> 
> Fix a printf format mismatch warning seen on 64-bit builds.
> 
> Cc: Łukasz Majewski <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/usb/gadget/f_mass_storage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/drivers/usb/gadget/f_mass_storage.c index
> e045957d0723..71fd49db7f24 100644 ---
> a/drivers/usb/gadget/f_mass_storage.c +++
> b/drivers/usb/gadget/f_mass_storage.c @@ -973,7 +973,7 @@ static int
> do_write(struct fsg_common *common) 
>  			/* If an error occurred, report it and its
> position */ if (nwritten < amount) {
> -				printf("nwritten:%d amount:%d\n",
> nwritten,
> +				printf("nwritten:%zd amount:%u\n",
> nwritten, amount);
>  				curlun->sense_data = SS_WRITE_ERROR;
>  				curlun->info_valid = 1;

Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
[test HW - Exynos4210 Trats board]
Łukasz Majewski March 23, 2015, 10:23 a.m. UTC | #2 
Hi Thierry,

> From: Thierry Reding <treding@nvidia.com>
> 
> Fix a printf format mismatch warning seen on 64-bit builds.
> 
> Cc: Łukasz Majewski <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/usb/gadget/f_mass_storage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/f_mass_storage.c
> b/drivers/usb/gadget/f_mass_storage.c index
> e045957d0723..71fd49db7f24 100644 ---
> a/drivers/usb/gadget/f_mass_storage.c +++
> b/drivers/usb/gadget/f_mass_storage.c @@ -973,7 +973,7 @@ static int
> do_write(struct fsg_common *common) 
>  			/* If an error occurred, report it and its
> position */ if (nwritten < amount) {
> -				printf("nwritten:%d amount:%d\n",
> nwritten,
> +				printf("nwritten:%zd amount:%u\n",
> nwritten, amount);
>  				curlun->sense_data = SS_WRITE_ERROR;
>  				curlun->info_valid = 1;

Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
Marek Vasut March 25, 2015, 11:43 a.m. UTC | #3 
On Friday, March 20, 2015 at 12:41:25 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Fix a printf format mismatch warning seen on 64-bit builds.
> 
> Cc: Łukasz Majewski <l.majewski@samsung.com>
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Applied, thanks!

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c
index e045957d0723..71fd49db7f24 100644
--- a/drivers/usb/gadget/f_mass_storage.c
+++ b/drivers/usb/gadget/f_mass_storage.c
@@ -973,7 +973,7 @@  static int do_write(struct fsg_common *common)
 
 			/* If an error occurred, report it and its position */
 			if (nwritten < amount) {
-				printf("nwritten:%d amount:%d\n", nwritten,
+				printf("nwritten:%zd amount:%u\n", nwritten,
 				       amount);
 				curlun->sense_data = SS_WRITE_ERROR;
 				curlun->info_valid = 1;