From patchwork Fri Feb 12 20:55:56 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adam Litke X-Patchwork-Id: 45212 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9EEB1B7CB8 for ; Sat, 13 Feb 2010 08:08:50 +1100 (EST) Received: from localhost ([127.0.0.1]:47107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ng2bv-0006d5-No for incoming@patchwork.ozlabs.org; Fri, 12 Feb 2010 15:59:35 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ng2Yj-0005on-Nb for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:56:17 -0500 Received: from [199.232.76.173] (port=48818 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ng2Yj-0005oU-7C for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:56:17 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ng2Yi-00024D-Ha for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:56:17 -0500 Received: from e31.co.us.ibm.com ([32.97.110.149]:44307) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ng2Yi-00023u-3R for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:56:16 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o1CKlhiI006456 for ; Fri, 12 Feb 2010 13:47:43 -0700 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o1CKtws6062000 for ; Fri, 12 Feb 2010 13:55:59 -0700 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o1CKwDr8014032 for ; Fri, 12 Feb 2010 13:58:14 -0700 Received: from [9.49.158.185] (sig-9-49-158-185.mts.ibm.com [9.49.158.185]) by d03av06.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVin) with ESMTP id o1CKwCXu013959; Fri, 12 Feb 2010 13:58:13 -0700 From: Adam Litke To: Anthony Liguori Organization: IBM Date: Fri, 12 Feb 2010 14:55:56 -0600 Message-ID: <1266008156.3474.18.camel@aglitke> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Arghh... Adding missing S-O-B Hi Anthony. I wonder if there was a problem when importing my async command handler patchset. Since the 'balloon' command completes immediately, it must call the completion callback before returning. That call was missing but is added by the patch below. Signed-off-by: Adam Litke diff --git a/monitor.c b/monitor.c index ae125b8..f94794d 100644 --- a/monitor.c +++ b/monitor.c @@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params, return -1; } + cb(opaque, NULL); return 0; }