| Message ID | 1426771420-29979-1-git-send-email-nicolas.iooss_linux@m4x.org |
|---|---|
| State | Awaiting Upstream, archived |
| Delegated to: | David Miller |
| Headers | show |
Marcel, On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote: > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") Acked-by: Alexander Aring <alex.aring@gmail.com> can you please queue this into bluetooth-next or even bluetooth? Thanks. - Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-03-19 at 14:37 +0100, Alexander Aring wrote: > On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote: > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > > Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") > > Acked-by: Alexander Aring <alex.aring@gmail.com> > > can you please queue this into bluetooth-next or even bluetooth? Is the Fixes: tag needed? mac802154.ko builds fine on my machine. There's also no error or warning included in the commit explanation. So it seems this is just a typo fix, not something that should be sent to stable too. Or did I miss something non-obvious? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 19, 2015 at 02:46:26PM +0100, Paul Bolle wrote: > On Thu, 2015-03-19 at 14:37 +0100, Alexander Aring wrote: > > On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote: > > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > > > Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") > > > > Acked-by: Alexander Aring <alex.aring@gmail.com> > > > > can you please queue this into bluetooth-next or even bluetooth? > > Is the Fixes: tag needed? > > mac802154.ko builds fine on my machine. There's also no error or warning > included in the commit explanation. So it seems this is just a typo fix, > not something that should be sent to stable too. Or did I miss something > non-obvious? > It's only an internal header which is used by c-files inside net/mac802154. I am not sure the right handling of this kind of fix. That's why I said to Marcel bluetooth-next or even bluetooth. The header-guard working right now because the internal-header is included only once in a c-file in "net/mac802154". I currently imagine the following situation, when a stable patch comes in and add a: #include "driver-ops.h" in another internal header like "ieee802154_i.h" which is also part of net/mac802154/ directory. Then the build will fail afterwards, but I don't plan to send such patch to stable. Nevertheless, then some build robots should notice about that. If nobody other complains here, then I am fine to put this into bluetooth-next. - Alex -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/19/2015 09:46 PM, Paul Bolle wrote: > On Thu, 2015-03-19 at 14:37 +0100, Alexander Aring wrote: >> On Thu, Mar 19, 2015 at 09:23:40PM +0800, Nicolas Iooss wrote: >>> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> >>> Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") >> >> Acked-by: Alexander Aring <alex.aring@gmail.com> >> >> can you please queue this into bluetooth-next or even bluetooth? > > Is the Fixes: tag needed? > > mac802154.ko builds fine on my machine. There's also no error or warning > included in the commit explanation. So it seems this is just a typo fix, > not something that should be sent to stable too. Or did I miss something > non-obvious? No, you didn't miss anything. It is only a fix for a typo I found while testing LLVMLinux (clang warns about such typos with -Wheader-guard). I added a Fixes: tag because it is easier to remove it afterwards that to search for a commit when adding it. I think this patch should not be sent to stable@, and feel free to remove the tag if for you it means "forward to stable@" (Documentation/SubmittingPatches is not clear about whether a Fixes tag should be only used for real bugs or if it also applies to compiler warnings). Thanks for your quick replies. Nicolas -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Nicolas, > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") > --- > net/mac802154/driver-ops.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/mac802154/driver-ops.h b/net/mac802154/driver-ops.h index 98180a9fff4a..a0533357b9ea 100644 --- a/net/mac802154/driver-ops.h +++ b/net/mac802154/driver-ops.h @@ -1,4 +1,4 @@ -#ifndef __MAC802154_DRVIER_OPS +#ifndef __MAC802154_DRIVER_OPS #define __MAC802154_DRIVER_OPS #include <linux/types.h> @@ -220,4 +220,4 @@ drv_set_promiscuous_mode(struct ieee802154_local *local, bool on) return local->ops->set_promiscuous_mode(&local->hw, on); } -#endif /* __MAC802154_DRVIER_OPS */ +#endif /* __MAC802154_DRIVER_OPS */
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> Fixes: b6eea9ca354a ("mac802154: introduce driver-ops header") --- net/mac802154/driver-ops.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)