diff mbox

[PULL,24/24] qga/commands-posix: Fix resource leak

Message ID 8ce1ee4618f4a557959f5a5731f6726b30416df5.1426755483.git.mjt@msgid.tls.msk.ru
State New
Headers show

Commit Message

Michael Tokarev March 19, 2015, 9:05 a.m. UTC 
From: Shannon Zhao <zhaoshenglong@huawei.com>

It's detected by coverity. Close the dirfd.

Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 qga/commands-posix.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index d5bb5cb..ba8de62 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2283,6 +2283,7 @@  GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
 
     buf = g_malloc0(20);
     ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
+    close(dirfd);
     if (local_err) {
         g_free(buf);
         error_propagate(errp, local_err);