| Message ID | 1426693992-31163-9-git-send-email-ben.dooks@codethink.co.uk |
|---|---|
| State | Accepted |
| Headers | show |
On 15:53 Wed 18 Mar , Ben Dooks wrote: > Change the __raw IO calls to readl/write_relaxed which makes the driver > endian agnostic to run properly on big endian systems. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > -- > CC: Alessandro Zummo <a.zummo@towertech.it> > CC: rtc-linux@googlegroups.com > CC: linux-arm-kernel@lists.infradead.org > CC: Andrew Victor <linux@maxim.org.za> > CC: Nicolas Ferre <nicolas.ferre@atmel.com> > CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > --- > drivers/rtc/rtc-at91rm9200.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c > index b4f7744..4106abc 100644 > --- a/drivers/rtc/rtc-at91rm9200.c > +++ b/drivers/rtc/rtc-at91rm9200.c > @@ -37,9 +37,9 @@ > #include "rtc-at91rm9200.h" > > #define at91_rtc_read(field) \ > - __raw_readl(at91_rtc_regs + field) > + readl_relaxed(at91_rtc_regs + field) > #define at91_rtc_write(field, val) \ > - __raw_writel((val), at91_rtc_regs + field) > + writel_relaxed((val), at91_rtc_regs + field) I'm not against it but the SoC using it are Little only Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Best Regards, J. > > #define AT91_RTC_EPOCH 1900UL /* just like arch/arm/common/rtctime.c */ > > -- > 2.1.4 > > -- > -- > You received this message because you are subscribed to "rtc-linux". > Membership options at http://groups.google.com/group/rtc-linux . > Please read http://groups.google.com/group/rtc-linux/web/checklist > before submitting a driver. > --- > You received this message because you are subscribed to the Google Groups "rtc-linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.
On 19/03/15 09:02, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 15:53 Wed 18 Mar , Ben Dooks wrote: >> Change the __raw IO calls to readl/write_relaxed which makes the driver >> endian agnostic to run properly on big endian systems. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> -- >> CC: Alessandro Zummo <a.zummo@towertech.it> >> CC: rtc-linux@googlegroups.com >> CC: linux-arm-kernel@lists.infradead.org >> CC: Andrew Victor <linux@maxim.org.za> >> CC: Nicolas Ferre <nicolas.ferre@atmel.com> >> CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> >> --- >> drivers/rtc/rtc-at91rm9200.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c >> index b4f7744..4106abc 100644 >> --- a/drivers/rtc/rtc-at91rm9200.c >> +++ b/drivers/rtc/rtc-at91rm9200.c >> @@ -37,9 +37,9 @@ >> #include "rtc-at91rm9200.h" >> >> #define at91_rtc_read(field) \ >> - __raw_readl(at91_rtc_regs + field) >> + readl_relaxed(at91_rtc_regs + field) >> #define at91_rtc_write(field, val) \ >> - __raw_writel((val), at91_rtc_regs + field) >> + writel_relaxed((val), at91_rtc_regs + field) > > I'm not against it but the SoC using it are Little only It is used by the SAMA5D36 which is Cortex-A5 with big endian support.
Le 18/03/2015 16:53, Ben Dooks a écrit : > Change the __raw IO calls to readl/write_relaxed which makes the driver > endian agnostic to run properly on big endian systems. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > -- > CC: Alessandro Zummo <a.zummo@towertech.it> > CC: rtc-linux@googlegroups.com > CC: linux-arm-kernel@lists.infradead.org > CC: Andrew Victor <linux@maxim.org.za> > CC: Nicolas Ferre <nicolas.ferre@atmel.com> Yes, that seems neat: Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Thanks! > CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > --- > drivers/rtc/rtc-at91rm9200.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c > index b4f7744..4106abc 100644 > --- a/drivers/rtc/rtc-at91rm9200.c > +++ b/drivers/rtc/rtc-at91rm9200.c > @@ -37,9 +37,9 @@ > #include "rtc-at91rm9200.h" > > #define at91_rtc_read(field) \ > - __raw_readl(at91_rtc_regs + field) > + readl_relaxed(at91_rtc_regs + field) > #define at91_rtc_write(field, val) \ > - __raw_writel((val), at91_rtc_regs + field) > + writel_relaxed((val), at91_rtc_regs + field) > > #define AT91_RTC_EPOCH 1900UL /* just like arch/arm/common/rtctime.c */ > >
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index b4f7744..4106abc 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@ -37,9 +37,9 @@ #include "rtc-at91rm9200.h" #define at91_rtc_read(field) \ - __raw_readl(at91_rtc_regs + field) + readl_relaxed(at91_rtc_regs + field) #define at91_rtc_write(field, val) \ - __raw_writel((val), at91_rtc_regs + field) + writel_relaxed((val), at91_rtc_regs + field) #define AT91_RTC_EPOCH 1900UL /* just like arch/arm/common/rtctime.c */
Change the __raw IO calls to readl/write_relaxed which makes the driver endian agnostic to run properly on big endian systems. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> -- CC: Alessandro Zummo <a.zummo@towertech.it> CC: rtc-linux@googlegroups.com CC: linux-arm-kernel@lists.infradead.org CC: Andrew Victor <linux@maxim.org.za> CC: Nicolas Ferre <nicolas.ferre@atmel.com> CC: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> --- drivers/rtc/rtc-at91rm9200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)