| Submitter | Matthew Garrett |
|---|---|
| Date | Feb. 11, 2010, 4:29 p.m. |
| Message ID | <1265905767-3884-1-git-send-email-mjg@redhat.com> |
| Download | mbox | patch |
| Permalink | /patch/45137/ |
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
Comments
On Thu, 11 Feb 2010, Matthew Garrett wrote: > The 82537 errata and comment in e1000e_disable_l1aspm both agree that > only 82537L devices are affected. Limit the L1 disable to them. Hi Matthew, its a nitpick, but can you please change the part number to the correct one? it should be s/82537/82573 > Signed-off-by: Matthew Garrett <mjg@redhat.com> > --- > drivers/net/e1000e/netdev.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c > index 57f149b..27eed81 100644 > --- a/drivers/net/e1000e/netdev.c > +++ b/drivers/net/e1000e/netdev.c > @@ -4642,6 +4642,10 @@ static void e1000e_disable_l1aspm(struct pci_dev *pdev) > * Unfortunately this feature saves about 1W power consumption when > * active. > */ > + > + if (pdev->device != E1000_DEV_ID_82573L) > + return; > + > pos = pci_find_capability(pdev, PCI_CAP_ID_EXP); > pci_read_config_word(pdev, pos + PCI_EXP_LNKCTL, &val); > if (val & 0x2) { > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 11, 2010 at 09:17:12AM -0800, Brandeburg, Jesse wrote: > > > On Thu, 11 Feb 2010, Matthew Garrett wrote: > > > The 82537 errata and comment in e1000e_disable_l1aspm both agree that > > only 82537L devices are affected. Limit the L1 disable to them. > > Hi Matthew, its a nitpick, but can you please change the part number to > the correct one? it should be s/82537/82573 Whoops! Sorry, I'll do that.
Patch
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c index 57f149b..27eed81 100644 --- a/drivers/net/e1000e/netdev.c +++ b/drivers/net/e1000e/netdev.c @@ -4642,6 +4642,10 @@ static void e1000e_disable_l1aspm(struct pci_dev *pdev) * Unfortunately this feature saves about 1W power consumption when * active. */ + + if (pdev->device != E1000_DEV_ID_82573L) + return; + pos = pci_find_capability(pdev, PCI_CAP_ID_EXP); pci_read_config_word(pdev, pos + PCI_EXP_LNKCTL, &val); if (val & 0x2) {
The 82537 errata and comment in e1000e_disable_l1aspm both agree that only 82537L devices are affected. Limit the L1 disable to them. Signed-off-by: Matthew Garrett <mjg@redhat.com> --- drivers/net/e1000e/netdev.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)