Patchwork 9p: fix return value of rdma_request()

login
register
mail settings
Submitter Dan Carpenter
Date Feb. 11, 2010, 8:20 a.m.
Message ID <20100211082044.GE14210@bicker>
Download mbox | patch
Permalink /patch/45113/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Dan Carpenter - Feb. 11, 2010, 8:20 a.m.
rdma_request() is supposed to return negative values on error.  This change
means that if a kmalloc() fails it returns -ENOMEM.  The original code returned
certain negative values, zero on success and zero on kmalloc() failures.

Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I was just reading the code and I noticed this bug.  I haven't tested it because I
don't have the hardware.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 2c95a89..589e340 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -419,7 +419,7 @@  static int rdma_request(struct p9_client *client, struct p9_req_t *req)
 	struct p9_trans_rdma *rdma = client->trans;
 	struct ib_send_wr wr, *bad_wr;
 	struct ib_sge sge;
-	int err = 0;
+	int err = -ENOMEM;
 	unsigned long flags;
 	struct p9_rdma_context *c = NULL;
 	struct p9_rdma_context *rpl_context = NULL;