diff mbox

[v2,2/3] leds: ktd2692: add device tree bindings for ktd2692

Message ID 1426581951-11869-3-git-send-email-ingi2.kim@samsung.com
State Superseded, archived
Headers show

Commit Message

Ingi Kim March 17, 2015, 8:45 a.m. UTC
This patch adds the device tree bindings for ktd2692 flash LEDs.
Add optional properties 'flash-timeout-us' to control flash timeout
and 'vin-supply' for flash-led regulator

Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
---
 .../devicetree/bindings/leds/leds-ktd2692.txt      | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt

Comments

Jaehoon Chung March 17, 2015, 10:40 p.m. UTC | #1
On 03/17/2015 05:45 PM, Ingi Kim wrote:
> This patch adds the device tree bindings for ktd2692 flash LEDs.
> Add optional properties 'flash-timeout-us' to control flash timeout
> and 'vin-supply' for flash-led regulator
> 
> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
> ---
>  .../devicetree/bindings/leds/leds-ktd2692.txt      | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
> new file mode 100644
> index 0000000..1b44225
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
> @@ -0,0 +1,37 @@
> +* Kinetic Technologies - KTD2692 Flash LED Driver
> +
> +KTD2692 is the ideal power solution for high-power flash LEDs.
> +It uses ExpressWire single-wire programming for maximum flexibility.
> +
> +The ExpressWire interface through CTRL pin can control LED on/off and
> +enable/disable the IC, Movie/Flash mode current, Flash timeout,
> +LVP(low voltage protection).
> +
> +Required properties:
> +	- compatible: "kinetic,ktd2692"
> +	- ctrl-gpio : gpio pin in order control ktd2692 flash led.
> +		There is an internal 300kOhm pull-down resistor at this pin
> +	- supply : "vin" LED supply
> +
> +Optional property:
> +	- flash-timeout-us : Maximum flash timeout in microseconds.
> +			flash timeout ranges from 0 to 1835000us and
> +			default is 1049000us.
> +
> +Example:
> +
> +vbat: fixedregulator@0 {
> +	compatible = "regulator-fixed";
> +	regulator-name = "vbat-supply";
> +	regulator-min-microvolt = <5000000>;
> +	regulator-max-microvolt = <5000000>;
> +	gpio = <>;

gpio = <> ? What do you mean?
And this is described at Documentation/devicetree/bindings/regulator/fixed-regulator.txt
I'm not sure whether this example really needs.

Best Regards,
Jaehoon Chung

> +	regulator-always-on;
> +};
> +
> +flash-led {
> +	compatible = "kinetic,ktd2692";
> +	ctrl-gpio = <&gpc0 1 0>;
> +	flash-timeout-us = <1835000>;
> +	vin-supply = <&vbat>;
> +};
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ingi Kim March 18, 2015, 1:35 a.m. UTC | #2
Hi

On 2015년 03월 18일 07:40, Jaehoon Chung wrote:
> On 03/17/2015 05:45 PM, Ingi Kim wrote:
>> This patch adds the device tree bindings for ktd2692 flash LEDs.
>> Add optional properties 'flash-timeout-us' to control flash timeout
>> and 'vin-supply' for flash-led regulator
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@samsung.com>
>> ---
>>  .../devicetree/bindings/leds/leds-ktd2692.txt      | 37 ++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> new file mode 100644
>> index 0000000..1b44225
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> @@ -0,0 +1,37 @@
>> +* Kinetic Technologies - KTD2692 Flash LED Driver
>> +
>> +KTD2692 is the ideal power solution for high-power flash LEDs.
>> +It uses ExpressWire single-wire programming for maximum flexibility.
>> +
>> +The ExpressWire interface through CTRL pin can control LED on/off and
>> +enable/disable the IC, Movie/Flash mode current, Flash timeout,
>> +LVP(low voltage protection).
>> +
>> +Required properties:
>> +	- compatible: "kinetic,ktd2692"
>> +	- ctrl-gpio : gpio pin in order control ktd2692 flash led.
>> +		There is an internal 300kOhm pull-down resistor at this pin
>> +	- supply : "vin" LED supply
>> +
>> +Optional property:
>> +	- flash-timeout-us : Maximum flash timeout in microseconds.
>> +			flash timeout ranges from 0 to 1835000us and
>> +			default is 1049000us.
>> +
>> +Example:
>> +
>> +vbat: fixedregulator@0 {
>> +	compatible = "regulator-fixed";
>> +	regulator-name = "vbat-supply";
>> +	regulator-min-microvolt = <5000000>;
>> +	regulator-max-microvolt = <5000000>;
>> +	gpio = <>;
> 
> gpio = <> ? What do you mean?
> And this is described at Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> I'm not sure whether this example really needs.
> 
> Best Regards,
> Jaehoon Chung
> 

I just want to show that dummy regulator can be used with flash-led.
As you mentioned earlier, remove unnecessary example and add refer comment 

Thanks,
Ingi Kim

>> +	regulator-always-on;
>> +};
>> +
>> +flash-led {
>> +	compatible = "kinetic,ktd2692";
>> +	ctrl-gpio = <&gpc0 1 0>;
>> +	flash-timeout-us = <1835000>;
>> +	vin-supply = <&vbat>;
>> +};
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
new file mode 100644
index 0000000..1b44225
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
@@ -0,0 +1,37 @@ 
+* Kinetic Technologies - KTD2692 Flash LED Driver
+
+KTD2692 is the ideal power solution for high-power flash LEDs.
+It uses ExpressWire single-wire programming for maximum flexibility.
+
+The ExpressWire interface through CTRL pin can control LED on/off and
+enable/disable the IC, Movie/Flash mode current, Flash timeout,
+LVP(low voltage protection).
+
+Required properties:
+	- compatible: "kinetic,ktd2692"
+	- ctrl-gpio : gpio pin in order control ktd2692 flash led.
+		There is an internal 300kOhm pull-down resistor at this pin
+	- supply : "vin" LED supply
+
+Optional property:
+	- flash-timeout-us : Maximum flash timeout in microseconds.
+			flash timeout ranges from 0 to 1835000us and
+			default is 1049000us.
+
+Example:
+
+vbat: fixedregulator@0 {
+	compatible = "regulator-fixed";
+	regulator-name = "vbat-supply";
+	regulator-min-microvolt = <5000000>;
+	regulator-max-microvolt = <5000000>;
+	gpio = <>;
+	regulator-always-on;
+};
+
+flash-led {
+	compatible = "kinetic,ktd2692";
+	ctrl-gpio = <&gpc0 1 0>;
+	flash-timeout-us = <1835000>;
+	vin-supply = <&vbat>;
+};