From patchwork Mon Mar 16 21:48:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 450766 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AE16C14007F for ; Tue, 17 Mar 2015 08:49:06 +1100 (AEDT) Received: from localhost ([::1]:51791 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXcsi-0006Qk-P1 for incoming@patchwork.ozlabs.org; Mon, 16 Mar 2015 17:49:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXcsK-0005qE-Ul for qemu-devel@nongnu.org; Mon, 16 Mar 2015 17:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXcsH-0001pv-OT for qemu-devel@nongnu.org; Mon, 16 Mar 2015 17:48:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37686 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXcsH-0001pT-Ie; Mon, 16 Mar 2015 17:48:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2C258ABD1; Mon, 16 Mar 2015 21:48:36 +0000 (UTC) Message-ID: <55074FB1.5070607@suse.de> Date: Mon, 16 Mar 2015 17:48:33 -0400 From: Alexander Graf User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Stefan Weil , QEMU Developer References: <1426346950-7982-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1426346950-7982-1-git-send-email-sw@weilnetz.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-Received-From: 195.135.220.15 Cc: qemu-ppc@nongnu.org Subject: Re: [Qemu-devel] [PATCH] spapr: Add missing checks for NULL pointers and report failures X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 14.03.15 11:29, Stefan Weil wrote: > This fixes potential runtime crashes and two warnings from Coverity. > > The new error message does not add a prefix "qemu:" because that is > already done in function hw_error. It also starts with an uppercase > letter because that seems to be the mostly used form. > > Signed-off-by: Stefan Weil I've squashed the patch below into your commit as well. Alex diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 9c87a70..7febff7 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -1507,7 +1507,7 @@ static void ppc_spapr_init(MachineState *machine) filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "spapr-rtas.bin"); if (!filename) { - hw_error("Could not find LPAR rtas '%s'\n", spapr-rtas.bin); + hw_error("Could not find LPAR rtas '%s'\n", "spapr-rtas.bin"); exit(1); } spapr->rtas_size = get_image_size(filename);