Message ID | 0c2c4220e058b85ecf441bf0449632cbd0c64555.1426507460.git.peter.crosthwaite@xilinx.com |
---|---|
State | New |
Headers | show |
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote: > Use SMC PSCI, with the standard policy of secondaries starting in > power-off. > > Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> Looks good, Reviewed-by: Alistair Francis <alistair.francis@xilinx.com> Thanks, Alistair > --- > changed since v1: > Add &error_abort to property setter calls > > hw/arm/xlnx-zynqmp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c > index e015025..0265fba 100644 > --- a/hw/arm/xlnx-zynqmp.c > +++ b/hw/arm/xlnx-zynqmp.c > @@ -97,6 +97,14 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp) > for (i = 0; i < XLNX_ZYNQMP_NUM_CPUS; i++) { > qemu_irq irq; > > + object_property_set_int(OBJECT(&s->cpu[i]), QEMU_PSCI_CONDUIT_SMC, > + "psci-conduit", &error_abort); > + if (i > 0) { > + /* Secondary CPUs start in PSCI powered-down state */ > + object_property_set_bool(OBJECT(&s->cpu[i]), true, > + "start-powered-off", &error_abort); > + } > + > object_property_set_bool(OBJECT(&s->cpu[i]), true, "realized", &err); > ERR_PROP_CHECK_RETURN(err, errp); > > -- > 2.3.1.2.g90df61e.dirty > >
diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index e015025..0265fba 100644 --- a/hw/arm/xlnx-zynqmp.c +++ b/hw/arm/xlnx-zynqmp.c @@ -97,6 +97,14 @@ static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp) for (i = 0; i < XLNX_ZYNQMP_NUM_CPUS; i++) { qemu_irq irq; + object_property_set_int(OBJECT(&s->cpu[i]), QEMU_PSCI_CONDUIT_SMC, + "psci-conduit", &error_abort); + if (i > 0) { + /* Secondary CPUs start in PSCI powered-down state */ + object_property_set_bool(OBJECT(&s->cpu[i]), true, + "start-powered-off", &error_abort); + } + object_property_set_bool(OBJECT(&s->cpu[i]), true, "realized", &err); ERR_PROP_CHECK_RETURN(err, errp);
Use SMC PSCI, with the standard policy of secondaries starting in power-off. Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com> --- changed since v1: Add &error_abort to property setter calls hw/arm/xlnx-zynqmp.c | 8 ++++++++ 1 file changed, 8 insertions(+)