| Message ID | 1426456834-6308-6-git-send-email-afaerber@suse.de |
|---|---|
| State | New |
| Headers | show |
Hello Andreas, On Sun, Mar 15, 2015 at 11:00 PM, Andreas Färber <afaerber@suse.de> wrote: > Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > v2 -> v3: Unchanged > > v1 -> v2: > * Filled in Sob from Hakjoo Kim > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts > index 97310bb727e2..b02cd3ab7b38 100644 > --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts > +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts > @@ -15,6 +15,7 @@ > > /dts-v1/; > #include "exynos5410.dtsi" > +#include <dt-bindings/gpio/gpio.h> > / { > model = "ODROID-XU based on EXYNOS5410"; > compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5"; > @@ -39,6 +40,30 @@ > reg = <0x02037000 0x1000>; > }; > > + leds { > + compatible = "gpio-leds"; > + > + blue { > + label = "blue:heartbeat"; > + gpios = <&gpb2 2 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + linux,default-trigger = "heartbeat"; > + }; > + > + green { > + label = "green:activity"; > + gpios = <&gpb2 1 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + linux,default-trigger = "mmc0"; > + }; > + > + red { > + label = "red:activity"; > + gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>; > + default-state = "off"; > + linux,default-trigger = "mmc1"; > + }; I see that you are sorting alphabetically using the node name but for example in pinctrl lines we were sorting using the GPIO bank and offset so if we want to use the same policy here, this should be green, blue and red. Either way is good to me though so is up to you. Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Best regards, Javier
W dniu 16.03.2015 o 07:00, Andreas Färber pisze: > Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com> > Signed-off-by: Andreas Färber <afaerber@suse.de> > --- > v2 -> v3: Unchanged > > v1 -> v2: > * Filled in Sob from Hakjoo Kim > > arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) What is the rationale behind doing this in separate patch, not as part of 2/5? You can just add new board DTS with all of its features at once, but maybe I am missing something? Best regards, Krzysztof
Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski: > W dniu 16.03.2015 o 07:00, Andreas Färber pisze: >> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com> >> Signed-off-by: Andreas Färber <afaerber@suse.de> >> --- >> v2 -> v3: Unchanged >> >> v1 -> v2: >> * Filled in Sob from Hakjoo Kim >> >> arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) > > What is the rationale behind doing this in separate patch, not as part > of 2/5? You can just add new board DTS with all of its features at once, > but maybe I am missing something? This patch depends on the pinctrl driver, 2/5 on nothing. By keeping it a separate patch it was intended to go in more quickly (clear fail there ;)) and it's easier to review the actual changes - squashing is always easier than picking apart. Thanks for your review! Both me and Ben have follow-ups once this moves forward. Kind regards, Andreas
On 02.06.2015 22:38, Andreas Färber wrote: > Am 02.06.2015 um 22:02 schrieb Krzysztof Kozlowski: >> W dniu 16.03.2015 o 07:00, Andreas Färber pisze: >>> Signed-off-by: Hakjoo Kim <ruppi.kim@hardkernel.com> >>> Signed-off-by: Andreas Färber <afaerber@suse.de> >>> --- >>> v2 -> v3: Unchanged >>> >>> v1 -> v2: >>> * Filled in Sob from Hakjoo Kim >>> >>> arch/arm/boot/dts/exynos5410-odroidxu.dts | 25 +++++++++++++++++++++++++ >>> 1 file changed, 25 insertions(+) >> >> What is the rationale behind doing this in separate patch, not as part >> of 2/5? You can just add new board DTS with all of its features at once, >> but maybe I am missing something? > > This patch depends on the pinctrl driver, 2/5 on nothing. > > By keeping it a separate patch it was intended to go in more quickly > (clear fail there ;)) and it's easier to review the actual changes - > squashing is always easier than picking apart. OK, I'm fine with it. The patch looks good: Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Can you resend everything with the change in chosen/console? Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts index 97310bb727e2..b02cd3ab7b38 100644 --- a/arch/arm/boot/dts/exynos5410-odroidxu.dts +++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts @@ -15,6 +15,7 @@ /dts-v1/; #include "exynos5410.dtsi" +#include <dt-bindings/gpio/gpio.h> / { model = "ODROID-XU based on EXYNOS5410"; compatible = "hardkernel,odroid-xu", "samsung,exynos5410", "samsung,exynos5"; @@ -39,6 +40,30 @@ reg = <0x02037000 0x1000>; }; + leds { + compatible = "gpio-leds"; + + blue { + label = "blue:heartbeat"; + gpios = <&gpb2 2 GPIO_ACTIVE_HIGH>; + default-state = "off"; + linux,default-trigger = "heartbeat"; + }; + + green { + label = "green:activity"; + gpios = <&gpb2 1 GPIO_ACTIVE_HIGH>; + default-state = "off"; + linux,default-trigger = "mmc0"; + }; + + red { + label = "red:activity"; + gpios = <&gpx2 3 GPIO_ACTIVE_HIGH>; + default-state = "off"; + linux,default-trigger = "mmc1"; + }; + }; }; &mmc_0 {