Patchwork [5/6] powerpc: Fix lwsync patching code on 64bit

login
register
mail settings
Submitter Anton Blanchard
Date Feb. 10, 2010, 11:07 a.m.
Message ID <20100210110719.GE3399@kryten>
Download mbox | patch
Permalink /patch/45011/
State Accepted, archived
Commit 53eae2281ad2607fa66a8ad1cb06186c8900da56
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Anton Blanchard - Feb. 10, 2010, 11:07 a.m.
do_lwsync_fixups doesn't work on 64bit, we end up writing lwsyncs to the
wrong addresses:

0:mon> di c0000001000bfacc
c0000001000bfacc  7c2004ac      lwsync

Since the lwsync section has negative offsets we need to use a signed int
pointer so we sign extend the value.

Signed-off-by: Anton Blanchard <anton@samba.org>
---

Patch

Index: powerpc.git/arch/powerpc/lib/feature-fixups.c
===================================================================
--- powerpc.git.orig/arch/powerpc/lib/feature-fixups.c	2010-02-10 18:34:32.645573355 +1100
+++ powerpc.git/arch/powerpc/lib/feature-fixups.c	2010-02-10 18:35:18.525571521 +1100
@@ -112,7 +112,7 @@  void do_feature_fixups(unsigned long val
 
 void do_lwsync_fixups(unsigned long value, void *fixup_start, void *fixup_end)
 {
-	unsigned int *start, *end, *dest;
+	int *start, *end, *dest;
 
 	if (!(value & CPU_FTR_LWSYNC))
 		return ;