diff mbox

[v3,1/7] Bug fix: delete the reader entry after queueing an event, not before.

Message ID 1426275924-1904-2-git-send-email-jwhite@codeweavers.com
State New
Headers show

Commit Message

Jeremy White March 13, 2015, 7:45 p.m. UTC 
As far as I can tell, the vreader_remove_reader function is not presently in
use anywhere; I have an upcoming patch set that uses it.

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
---
 libcacard/vreader.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc-André Lureau March 25, 2015, 3:12 p.m. UTC | #1 
ACK.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

On Fri, Mar 13, 2015 at 8:45 PM, Jeremy White <jwhite@codeweavers.com> wrote:
> As far as I can tell, the vreader_remove_reader function is not presently in
> use anywhere; I have an upcoming patch set that uses it.
>
> Signed-off-by: Jeremy White <jwhite@codeweavers.com>
> ---
>  libcacard/vreader.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libcacard/vreader.c b/libcacard/vreader.c
> index 0315dd8..8b10d6a 100644
> --- a/libcacard/vreader.c
> +++ b/libcacard/vreader.c
> @@ -529,8 +529,8 @@ vreader_remove_reader(VReader *reader)
>      }
>      vreader_dequeue(vreader_list, current_entry);
>      vreader_list_unlock();
> -    vreader_list_entry_delete(current_entry);
>      vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL));
> +    vreader_list_entry_delete(current_entry);
>      return VREADER_OK;
>  }
>
> --
> 1.7.10.4
>
>
diff mbox

Patch

diff --git a/libcacard/vreader.c b/libcacard/vreader.c
index 0315dd8..8b10d6a 100644
--- a/libcacard/vreader.c
+++ b/libcacard/vreader.c
@@ -529,8 +529,8 @@  vreader_remove_reader(VReader *reader)
     }
     vreader_dequeue(vreader_list, current_entry);
     vreader_list_unlock();
-    vreader_list_entry_delete(current_entry);
     vevent_queue_vevent(vevent_new(VEVENT_READER_REMOVE, reader, NULL));
+    vreader_list_entry_delete(current_entry);
     return VREADER_OK;
 }