diff mbox

[04/15] toolchain: remove LARGEFILE selects

Message ID 1426270934-15499-5-git-send-email-gustavo@zacarias.com.ar
State Superseded
Headers show

Commit Message

Gustavo Zacarias March 13, 2015, 6:22 p.m. UTC
There's no need for toolchains or the user to declare largefile support
since it's now mandatory.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 toolchain/Config.in                    |  2 --
 toolchain/toolchain-external/Config.in | 13 -------------
 2 files changed, 15 deletions(-)

Comments

Yann E. MORIN March 14, 2015, 10:36 p.m. UTC | #1
Gustavo, All,

On 2015-03-13 15:22 -0300, Gustavo Zacarias spake thusly:
> There's no need for toolchains or the user to declare largefile support
> since it's now mandatory.

With the new patch I suggested you had before patch 3, do not forget to
also remove the select from BR2_TOOLCHAIN_BUILDROOT_LARGEFILE in this
patch.

Regards,
Yann E. MORIN.

> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  toolchain/Config.in                    |  2 --
>  toolchain/toolchain-external/Config.in | 13 -------------
>  2 files changed, 15 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index b039ee2..291db94 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -9,7 +9,6 @@ config BR2_TOOLCHAIN
>  # Should be selected for glibc or eglibc
>  config BR2_TOOLCHAIN_USES_GLIBC
>  	bool
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_USE_WCHAR
>  	select BR2_ENABLE_LOCALE
> @@ -24,7 +23,6 @@ config BR2_TOOLCHAIN_USES_UCLIBC
>  
>  config BR2_TOOLCHAIN_USES_MUSL
>  	bool
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_USE_WCHAR
>  	select BR2_ENABLE_LOCALE
> diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
> index d29bf43..0c3340a 100644
> --- a/toolchain/toolchain-external/Config.in
> +++ b/toolchain/toolchain-external/Config.in
> @@ -635,7 +635,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103
>  	depends on BR2_sh2a
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
>  	select BR2_TOOLCHAIN_HAS_THREADS
> @@ -655,7 +654,6 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009
>  	depends on BR2_sh2a
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
> -	select BR2_LARGEFILE
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
>  	select BR2_TOOLCHAIN_HAS_THREADS
> @@ -782,7 +780,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -800,7 +797,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -818,7 +814,6 @@ config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>  	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
>  	select BR2_INSTALL_LIBSTDCPP
> -	select BR2_LARGEFILE
>  	select BR2_INET_IPV6
>  	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
>  	select BR2_USE_WCHAR
> @@ -1132,14 +1127,6 @@ endchoice
>  
>  if BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
>  
> -config BR2_TOOLCHAIN_EXTERNAL_LARGEFILE
> -	bool "Toolchain has large file support?"
> -	select BR2_LARGEFILE
> -	help
> -	  Select this option if your external toolchain supports
> -	  largefile. If you don't know, leave the default value,
> -	  Buildroot will tell you if it's correct or not.
> -
>  config BR2_TOOLCHAIN_EXTERNAL_INET_IPV6
>  	bool "Toolchain has IPv6 support?"
>  	select BR2_INET_IPV6
> -- 
> 2.0.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Gustavo Zacarias March 17, 2015, 3:11 p.m. UTC | #2
On 03/14/2015 07:36 PM, Yann E. MORIN wrote:

> Gustavo, All,
> 
> On 2015-03-13 15:22 -0300, Gustavo Zacarias spake thusly:
>> There's no need for toolchains or the user to declare largefile support
>> since it's now mandatory.
> 
> With the new patch I suggested you had before patch 3, do not forget to
> also remove the select from BR2_TOOLCHAIN_BUILDROOT_LARGEFILE in this
> patch.
> 
> Regards,
> Yann E. MORIN.

The only place where BR2_TOOLCHAIN_BUILDROOT_LARGEFILE is selected/used
is in defconfigs, so there's no need for anything additional in this
patch (that's handled in patch 8).
Regards.
diff mbox

Patch

diff --git a/toolchain/Config.in b/toolchain/Config.in
index b039ee2..291db94 100644
--- a/toolchain/Config.in
+++ b/toolchain/Config.in
@@ -9,7 +9,6 @@  config BR2_TOOLCHAIN
 # Should be selected for glibc or eglibc
 config BR2_TOOLCHAIN_USES_GLIBC
 	bool
-	select BR2_LARGEFILE
 	select BR2_INET_IPV6
 	select BR2_USE_WCHAR
 	select BR2_ENABLE_LOCALE
@@ -24,7 +23,6 @@  config BR2_TOOLCHAIN_USES_UCLIBC
 
 config BR2_TOOLCHAIN_USES_MUSL
 	bool
-	select BR2_LARGEFILE
 	select BR2_INET_IPV6
 	select BR2_USE_WCHAR
 	select BR2_ENABLE_LOCALE
diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in
index d29bf43..0c3340a 100644
--- a/toolchain/toolchain-external/Config.in
+++ b/toolchain/toolchain-external/Config.in
@@ -635,7 +635,6 @@  config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201103
 	depends on BR2_sh2a
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
-	select BR2_LARGEFILE
 	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_USE_WCHAR
 	select BR2_TOOLCHAIN_HAS_THREADS
@@ -655,7 +654,6 @@  config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_SH2A_201009
 	depends on BR2_sh2a
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
-	select BR2_LARGEFILE
 	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_USE_WCHAR
 	select BR2_TOOLCHAIN_HAS_THREADS
@@ -782,7 +780,6 @@  config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
 	select BR2_INSTALL_LIBSTDCPP
-	select BR2_LARGEFILE
 	select BR2_INET_IPV6
 	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_USE_WCHAR
@@ -800,7 +797,6 @@  config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
 	select BR2_INSTALL_LIBSTDCPP
-	select BR2_LARGEFILE
 	select BR2_INET_IPV6
 	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_USE_WCHAR
@@ -818,7 +814,6 @@  config BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
 	select BR2_TOOLCHAIN_EXTERNAL_UCLIBC
 	select BR2_INSTALL_LIBSTDCPP
-	select BR2_LARGEFILE
 	select BR2_INET_IPV6
 	select BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_USE_WCHAR
@@ -1132,14 +1127,6 @@  endchoice
 
 if BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
 
-config BR2_TOOLCHAIN_EXTERNAL_LARGEFILE
-	bool "Toolchain has large file support?"
-	select BR2_LARGEFILE
-	help
-	  Select this option if your external toolchain supports
-	  largefile. If you don't know, leave the default value,
-	  Buildroot will tell you if it's correct or not.
-
 config BR2_TOOLCHAIN_EXTERNAL_INET_IPV6
 	bool "Toolchain has IPv6 support?"
 	select BR2_INET_IPV6