| Message ID | 1426194899-14037-3-git-send-email-marek@goldelico.com |
|---|---|
| State | Needs Review / ACK, archived |
| Headers | show |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | total: 1 errors, 0 warnings, 0 lines checked |
| robh/patch-applied | success |
On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: > diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt > index 1ab6bc8..656165f 100644 > --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt > +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt > @@ -4,7 +4,6 @@ Required properties: > - compatible: "ti,omap-twl4030" > - ti,model: Name of the sound card (for example "omap3beagle") > - ti,mcbsp: phandle for the McBSP node > -- ti,codec: phandle for the twl4030 audio node As this was a required property, are you sure that no other operating system uses it? Even if not, you should probably change it to be an optional property, so that the existing dtbs do not become noncompliant after the change. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/13/2015 01:05 PM, Arnd Bergmann wrote: > On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> index 1ab6bc8..656165f 100644 >> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> @@ -4,7 +4,6 @@ Required properties: >> - compatible: "ti,omap-twl4030" >> - ti,model: Name of the sound card (for example "omap3beagle") >> - ti,mcbsp: phandle for the McBSP node >> -- ti,codec: phandle for the twl4030 audio node > > As this was a required property, are you sure that no other operating system > uses it? > > Even if not, you should probably change it to be an optional property, so > that the existing dtbs do not become noncompliant after the change. After I sent my Ack, I also started to think about the same thing. It is better to change it to optional.
On Fri, Mar 13, 2015 at 12:48 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > On 03/13/2015 01:05 PM, Arnd Bergmann wrote: >> On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >>> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> index 1ab6bc8..656165f 100644 >>> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> @@ -4,7 +4,6 @@ Required properties: >>> - compatible: "ti,omap-twl4030" >>> - ti,model: Name of the sound card (for example "omap3beagle") >>> - ti,mcbsp: phandle for the McBSP node >>> -- ti,codec: phandle for the twl4030 audio node >> >> As this was a required property, are you sure that no other operating system >> uses it? >> >> Even if not, you should probably change it to be an optional property, so >> that the existing dtbs do not become noncompliant after the change. > > After I sent my Ack, I also started to think about the same thing. It is > better to change it to optional. OK will do and post v2. Thanks. > > -- > Péter BR, marek
diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt index 1ab6bc8..656165f 100644 --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt @@ -4,7 +4,6 @@ Required properties: - compatible: "ti,omap-twl4030" - ti,model: Name of the sound card (for example "omap3beagle") - ti,mcbsp: phandle for the McBSP node -- ti,codec: phandle for the twl4030 audio node Optional properties: - ti,mcbsp-voice: phandle for the McBSP node connected to the voice port of twl @@ -59,5 +58,4 @@ sound { ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; };
ti,codec property is not necessary anymore thus removing references from documentation. Signed-off-by: Marek Belisko <marek@goldelico.com> --- Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- 1 file changed, 2 deletions(-)