From patchwork Tue Feb 9 17:31:46 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcelo Tosatti X-Patchwork-Id: 44940 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A9574B7D55 for ; Wed, 10 Feb 2010 04:42:39 +1100 (EST) Received: from localhost ([127.0.0.1]:46086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nety2-0002tA-Oj for incoming@patchwork.ozlabs.org; Tue, 09 Feb 2010 12:33:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NetwX-0002bj-Tp for qemu-devel@nongnu.org; Tue, 09 Feb 2010 12:32:09 -0500 Received: from [199.232.76.173] (port=39561 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NetwX-0002bD-Gu for qemu-devel@nongnu.org; Tue, 09 Feb 2010 12:32:09 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NetwV-0004A9-1X for qemu-devel@nongnu.org; Tue, 09 Feb 2010 12:32:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46860) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NetwU-00049F-5s for qemu-devel@nongnu.org; Tue, 09 Feb 2010 12:32:06 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o19HW2bH021602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 9 Feb 2010 12:32:02 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o19HW101001972; Tue, 9 Feb 2010 12:32:02 -0500 Received: from amt.cnet (vpn-10-215.rdu.redhat.com [10.11.10.215]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o19HW0dr023820; Tue, 9 Feb 2010 12:32:01 -0500 Received: from amt.cnet (amt.cnet [127.0.0.1]) by amt.cnet (Postfix) with ESMTP id 66FE266E051; Tue, 9 Feb 2010 15:31:47 -0200 (BRST) Received: (from marcelo@localhost) by amt.cnet (8.14.3/8.14.3/Submit) id o19HVkie001906; Tue, 9 Feb 2010 15:31:46 -0200 Date: Tue, 9 Feb 2010 15:31:46 -0200 From: Marcelo Tosatti To: qemu-devel@nongnu.org Message-ID: <20100209173146.GA1881@amt.cnet> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: xming Subject: [Qemu-devel] [PATCH] fix inet_parse typo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qemu_opt_set wants on/off, not yes/no. Signed-off-by: Marcelo Tosatti diff --git a/qemu-sockets.c b/qemu-sockets.c index 8850516..a88b2a7 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -424,7 +424,7 @@ static int inet_parse(QemuOpts *opts, const char *str) __FUNCTION__, str); return -1; } - qemu_opt_set(opts, "ipv6", "yes"); + qemu_opt_set(opts, "ipv6", "on"); } else if (qemu_isdigit(str[0])) { /* IPv4 addr */ if (2 != sscanf(str,"%64[0-9.]:%32[^,]%n",addr,port,&pos)) { @@ -432,7 +432,7 @@ static int inet_parse(QemuOpts *opts, const char *str) __FUNCTION__, str); return -1; } - qemu_opt_set(opts, "ipv4", "yes"); + qemu_opt_set(opts, "ipv4", "on"); } else { /* hostname */ if (2 != sscanf(str,"%64[^:]:%32[^,]%n",addr,port,&pos)) { @@ -450,9 +450,9 @@ static int inet_parse(QemuOpts *opts, const char *str) if (h) qemu_opt_set(opts, "to", h+4); if (strstr(optstr, ",ipv4")) - qemu_opt_set(opts, "ipv4", "yes"); + qemu_opt_set(opts, "ipv4", "on"); if (strstr(optstr, ",ipv6")) - qemu_opt_set(opts, "ipv6", "yes"); + qemu_opt_set(opts, "ipv6", "on"); return 0; }