Message ID | 1426130037-17956-12-git-send-email-scottwood@freescale.com |
---|---|
State | Superseded |
Delegated to: | David Miller |
Headers | show |
On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. Even on > other architectures, refrain from setting a bad example that people > copy. The commit message used uppercase 'S' and 'F'. But the patch uses lowercase variants. Is this to highlight the letter in the commit message or some unwanted inconsistency? Sam > > Signed-off-by: Scott Wood <scottwood@freescale.com> > Cc: sparclinux@vger.kernel.org > --- > arch/sparc/kernel/ds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c > index f87a55d..4ff835f 100644 > --- a/arch/sparc/kernel/ds.c > +++ b/arch/sparc/kernel/ds.c > @@ -875,7 +875,7 @@ void ldom_power_off(void) > > static void ds_conn_reset(struct ds_info *dp) > { > - printk(KERN_ERR "ds-%llu: ds_conn_reset() from %pf\n", > + printk(KERN_ERR "ds-%llu: ds_conn_reset() from %ps\n", > dp->id, __builtin_return_address(0)); > } > > -- > 2.1.0 > > -- > To unsubscribe from this list: send the line "unsubscribe sparclinux" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-03-12 at 19:47 +0100, Sam Ravnborg wrote: > On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote: > > Use %pS for actual addresses, otherwise you'll get bad output > > on arches like ppc64 where %pF expects a function descriptor. Even on > > other architectures, refrain from setting a bad example that people > > copy. > > The commit message used uppercase 'S' and 'F'. > But the patch uses lowercase variants. > > Is this to highlight the letter in the commit message or some unwanted inconsistency? It was copy and paste from others in the series that did involve the capital version. I can send a v2 with an updated commit message. -Scott -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 12, 2015 at 01:49:42PM -0500, Scott Wood wrote: > On Thu, 2015-03-12 at 19:47 +0100, Sam Ravnborg wrote: > > On Wed, Mar 11, 2015 at 10:13:47PM -0500, Scott Wood wrote: > > > Use %pS for actual addresses, otherwise you'll get bad output > > > on arches like ppc64 where %pF expects a function descriptor. Even on > > > other architectures, refrain from setting a bad example that people > > > copy. > > > > The commit message used uppercase 'S' and 'F'. > > But the patch uses lowercase variants. > > > > Is this to highlight the letter in the commit message or some unwanted inconsistency? > > It was copy and paste from others in the series that did involve the > capital version. I can send a v2 with an updated commit message. As it confused me someone else migth (maybe the chances are small but anyway) be confused too. So please send a new version. Sam -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c index f87a55d..4ff835f 100644 --- a/arch/sparc/kernel/ds.c +++ b/arch/sparc/kernel/ds.c @@ -875,7 +875,7 @@ void ldom_power_off(void) static void ds_conn_reset(struct ds_info *dp) { - printk(KERN_ERR "ds-%llu: ds_conn_reset() from %pf\n", + printk(KERN_ERR "ds-%llu: ds_conn_reset() from %ps\n", dp->id, __builtin_return_address(0)); }
Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Even on other architectures, refrain from setting a bad example that people copy. Signed-off-by: Scott Wood <scottwood@freescale.com> Cc: sparclinux@vger.kernel.org --- arch/sparc/kernel/ds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)