diff mbox

[U-Boot,1/2,v2] pci/layerscape: remove unnecessary pcie_layerscape.h

Message ID 1426129129-10149-1-git-send-email-Minghuan.Lian@freescale.com
State Accepted
Delegated to: York Sun
Headers show

Commit Message

Minghuan Lian March 12, 2015, 2:58 a.m. UTC 
The patch uses the common function name ft_pci_setup to replace
ft_pcie_setup, then removes unnecessary pcie_layerscape.h because
all the functions have been declared in common.h.

Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
---
change log:
v1-v2: remove unnecessary pcie_layerscape.h

 arch/arm/include/asm/pcie_layerscape.h  | 13 -------------
 board/freescale/ls1021aqds/ls1021aqds.c |  5 ++---
 board/freescale/ls1021atwr/ls1021atwr.c |  5 ++---
 drivers/pci/pcie_layerscape.c           |  5 ++---
 4 files changed, 6 insertions(+), 22 deletions(-)
 delete mode 100644 arch/arm/include/asm/pcie_layerscape.h

Comments

Tom Rini March 12, 2015, 12:25 p.m. UTC | #1 
On Thu, Mar 12, 2015 at 10:58:48AM +0800, Minghuan Lian wrote:

> The patch uses the common function name ft_pci_setup to replace
> ft_pcie_setup, then removes unnecessary pcie_layerscape.h because
> all the functions have been declared in common.h.
> 
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>

Thanks for reworking things!

Reviewed-by: Tom Rini <trini@konsulko.com>
York Sun April 23, 2015, 11:30 p.m. UTC | #2 
On 03/11/2015 07:58 PM, Minghuan Lian wrote:
> The patch uses the common function name ft_pci_setup to replace
> ft_pcie_setup, then removes unnecessary pcie_layerscape.h because
> all the functions have been declared in common.h.
> 
> Signed-off-by: Minghuan Lian <Minghuan.Lian@freescale.com>
> ---
> change log:
> v1-v2: remove unnecessary pcie_layerscape.h
> 

Applied to fsl-qoriq master, awaiting upstream.

York
diff mbox

Patch

diff --git a/arch/arm/include/asm/pcie_layerscape.h b/arch/arm/include/asm/pcie_layerscape.h
deleted file mode 100644
index fb08578..0000000
--- a/arch/arm/include/asm/pcie_layerscape.h
+++ /dev/null
@@ -1,13 +0,0 @@ 
-/*
- * Copyright 2014 Freescale Semiconductor, Inc.
- *
- * SPDX-License-Identifier:	GPL-2.0+
- */
-
-#ifndef __PCIE_LAYERSCAPE_H_
-#define __PCIE_LAYERSCAPE_H_
-
-void pci_init_board(void);
-void ft_pcie_setup(void *blob, bd_t *bd);
-
-#endif
diff --git a/board/freescale/ls1021aqds/ls1021aqds.c b/board/freescale/ls1021aqds/ls1021aqds.c
index 722b88f..bcd4361 100644
--- a/board/freescale/ls1021aqds/ls1021aqds.c
+++ b/board/freescale/ls1021aqds/ls1021aqds.c
@@ -12,7 +12,6 @@ 
 #include <asm/arch/clock.h>
 #include <asm/arch/fsl_serdes.h>
 #include <asm/arch/ls102xa_stream_id.h>
-#include <asm/pcie_layerscape.h>
 #include <hwconfig.h>
 #include <mmc.h>
 #include <fsl_esdhc.h>
@@ -595,8 +594,8 @@  int ft_board_setup(void *blob, bd_t *bd)
 {
 	ft_cpu_setup(blob, bd);
 
-#ifdef CONFIG_PCIE_LAYERSCAPE
-	ft_pcie_setup(blob, bd);
+#ifdef CONFIG_PCI
+	ft_pci_setup(blob, bd);
 #endif
 
 	return 0;
diff --git a/board/freescale/ls1021atwr/ls1021atwr.c b/board/freescale/ls1021atwr/ls1021atwr.c
index fb8525f..53fc4f8 100644
--- a/board/freescale/ls1021atwr/ls1021atwr.c
+++ b/board/freescale/ls1021atwr/ls1021atwr.c
@@ -12,7 +12,6 @@ 
 #include <asm/arch/clock.h>
 #include <asm/arch/fsl_serdes.h>
 #include <asm/arch/ls102xa_stream_id.h>
-#include <asm/pcie_layerscape.h>
 #include <mmc.h>
 #include <fsl_esdhc.h>
 #include <fsl_ifc.h>
@@ -475,8 +474,8 @@  int ft_board_setup(void *blob, bd_t *bd)
 {
 	ft_cpu_setup(blob, bd);
 
-#ifdef CONFIG_PCIE_LAYERSCAPE
-	ft_pcie_setup(blob, bd);
+#ifdef CONFIG_PCI
+	ft_pci_setup(blob, bd);
 #endif
 
 	return 0;
diff --git a/drivers/pci/pcie_layerscape.c b/drivers/pci/pcie_layerscape.c
index bcad8f2..1b0b814 100644
--- a/drivers/pci/pcie_layerscape.c
+++ b/drivers/pci/pcie_layerscape.c
@@ -11,7 +11,6 @@ 
 #include <asm/io.h>
 #include <errno.h>
 #include <malloc.h>
-#include <asm/pcie_layerscape.h>
 
 #ifndef CONFIG_SYS_PCI_MEMORY_BUS
 #define CONFIG_SYS_PCI_MEMORY_BUS CONFIG_SYS_SDRAM_BASE
@@ -486,7 +485,7 @@  static void ft_pcie_ls_setup(void *blob, const char *pci_compat,
 		fdt_set_node_status(blob, off, FDT_STATUS_DISABLED, 0);
 }
 
-void ft_pcie_setup(void *blob, bd_t *bd)
+void ft_pci_setup(void *blob, bd_t *bd)
 {
 	#ifdef CONFIG_PCIE1
 	ft_pcie_ls_setup(blob, FSL_PCIE_COMPAT, CONFIG_SYS_PCIE1_ADDR, PCIE1);
@@ -506,7 +505,7 @@  void ft_pcie_setup(void *blob, bd_t *bd)
 }
 
 #else
-void ft_pcie_setup(void *blob, bd_t *bd)
+void ft_pci_setup(void *blob, bd_t *bd)
 {
 }
 #endif