diff mbox

[U-Boot,1/2] mx6_common: Do not select esdhc DDR mode for all boards

Message ID 1426125135-6984-1-git-send-email-festevam@gmail.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam March 12, 2015, 1:52 a.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
have a DDR-capable eMMC, so remove this option from common code to avoid
regressions.

Reported-by: Stefan Roese <sr@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx6_common.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Otavio Salvador March 12, 2015, 3:48 a.m. UTC | #1 
On Wed, Mar 11, 2015 at 10:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
> have a DDR-capable eMMC, so remove this option from common code to avoid
> regressions.
>
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>


Acked-by: Otavio Salvador <otavio@ossystems.com.br>
Volodymyr Riazantsev March 12, 2015, 4:42 a.m. UTC | #2 
On Wed, Mar 11, 2015 at 11:48 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Mar 11, 2015 at 10:52 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
>> have a DDR-capable eMMC, so remove this option from common code to avoid
>> regressions.
>>
>> Reported-by: Stefan Roese <sr@denx.de>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
>
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Reviewed-by: Volodymyr Riazantsev <volodymyr.riazantsev@globallogic.com>

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Volodymyr Riazantsev
Stefan Roese March 12, 2015, 8:29 a.m. UTC | #3 
On 12.03.2015 02:52, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
> have a DDR-capable eMMC, so remove this option from common code to avoid
> regressions.
>
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

These 2 patches fix this DDR issue on my board. So:

Tested-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Stefano Babic March 13, 2015, 12:36 p.m. UTC | #4 
On 12/03/2015 02:52, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE should be selected only by boards that really
> have a DDR-capable eMMC, so remove this option from common code to avoid
> regressions.
> 
> Reported-by: Stefan Roese <sr@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/mx6_common.h b/include/configs/mx6_common.h
index 29b72b2..e0528ce 100644
--- a/include/configs/mx6_common.h
+++ b/include/configs/mx6_common.h
@@ -28,8 +28,6 @@ 
 #define CONFIG_SYS_PL310_BASE	L2_PL310_BASE
 #endif
 
-#define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
-
 #define CONFIG_MP
 #define CONFIG_MXC_GPT_HCLK