gpio: fix constconst in devres
diff mbox

Message ID 1426073078-25029-1-git-send-email-linus.walleij@linaro.org
State New
Headers show

Commit Message

Linus Walleij March 11, 2015, 11:24 a.m. UTC
Commit 1feb57a245a4910b03202a814ffc51a900bd4aca
"gpio: add parameter to allow the use named gpios"
includes a double-conted array. Fix this.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Olliver Schinagl <oliver@schinagl.nl>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/gpio/devres.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rojhalat Ibrahim March 11, 2015, 12:22 p.m. UTC | #1
On Wednesday 11 March 2015 12:24:38 Linus Walleij wrote:
> Commit 1feb57a245a4910b03202a814ffc51a900bd4aca
> "gpio: add parameter to allow the use named gpios"
> includes a double-conted array. Fix this.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Olliver Schinagl <oliver@schinagl.nl>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  drivers/gpio/devres.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
> index ec24da2418b3..0bd060bf7151 100644
> --- a/drivers/gpio/devres.c
> +++ b/drivers/gpio/devres.c
> @@ -135,7 +135,7 @@ struct gpio_desc *devm_get_gpiod_from_child(struct device *dev,
>  					    const char *con_id,
>  					    struct fwnode_handle *child)
>  {
> -	static const char const *suffixes[] = { "gpios", "gpio" };
> +	static const char *suffixes[] = { "gpios", "gpio" };
>  	char prop_name[32]; /* 32 is max size of property name */
>  	struct gpio_desc **dr;
>  	struct gpio_desc *desc;
> 

Shouldn't it be const char * const suffixes[], as in a const pointer to const data?

Wouldn't it be better to add an #include "gpiolib.h" to devres.c and use
the gpio_suffixes array defined in gliolib.h?


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Olliver Schinagl March 11, 2015, 12:48 p.m. UTC | #2
Hey all,

On 11-03-15 13:22, Rojhalat Ibrahim wrote:
> On Wednesday 11 March 2015 12:24:38 Linus Walleij wrote:
>> Commit 1feb57a245a4910b03202a814ffc51a900bd4aca
>> "gpio: add parameter to allow the use named gpios"
>> includes a double-conted array. Fix this.
>>
>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>> Cc: Olliver Schinagl <oliver@schinagl.nl>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> ---
>>   drivers/gpio/devres.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
>> index ec24da2418b3..0bd060bf7151 100644
>> --- a/drivers/gpio/devres.c
>> +++ b/drivers/gpio/devres.c
>> @@ -135,7 +135,7 @@ struct gpio_desc *devm_get_gpiod_from_child(struct device *dev,
>>   					    const char *con_id,
>>   					    struct fwnode_handle *child)
>>   {
>> -	static const char const *suffixes[] = { "gpios", "gpio" };
>> +	static const char *suffixes[] = { "gpios", "gpio" };
>>   	char prop_name[32]; /* 32 is max size of property name */
>>   	struct gpio_desc **dr;
>>   	struct gpio_desc *desc;
>>
> Shouldn't it be const char * const suffixes[], as in a const pointer to const data?
I sent a patch to fix this weeks ago I belive.
> Wouldn't it be better to add an #include "gpiolib.h" to devres.c and use
> the gpio_suffixes array defined in gliolib.h?
I did not know we had that, that sounds logical. I can cook up a patch 
for that to work on both invocations!

olliver
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rojhalat Ibrahim March 11, 2015, 2:23 p.m. UTC | #3
On Wednesday 11 March 2015 13:48:16 Olliver Schinagl wrote:
> Hey all,
> 
> On 11-03-15 13:22, Rojhalat Ibrahim wrote:
> > On Wednesday 11 March 2015 12:24:38 Linus Walleij wrote:
> >> Commit 1feb57a245a4910b03202a814ffc51a900bd4aca
> >> "gpio: add parameter to allow the use named gpios"
> >> includes a double-conted array. Fix this.
> >>
> >> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >> Cc: Olliver Schinagl <oliver@schinagl.nl>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> >> ---
> >>   drivers/gpio/devres.c | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
> >> index ec24da2418b3..0bd060bf7151 100644
> >> --- a/drivers/gpio/devres.c
> >> +++ b/drivers/gpio/devres.c
> >> @@ -135,7 +135,7 @@ struct gpio_desc *devm_get_gpiod_from_child(struct device *dev,
> >>   					    const char *con_id,
> >>   					    struct fwnode_handle *child)
> >>   {
> >> -	static const char const *suffixes[] = { "gpios", "gpio" };
> >> +	static const char *suffixes[] = { "gpios", "gpio" };
> >>   	char prop_name[32]; /* 32 is max size of property name */
> >>   	struct gpio_desc **dr;
> >>   	struct gpio_desc *desc;
> >>
> > Shouldn't it be const char * const suffixes[], as in a const pointer to const data?
> I sent a patch to fix this weeks ago I belive.
> > Wouldn't it be better to add an #include "gpiolib.h" to devres.c and use
> > the gpio_suffixes array defined in gliolib.h?
> I did not know we had that, that sounds logical. I can cook up a patch 
> for that to work on both invocations!
> 

The gpio_suffixes array in gpiolib.h was added only very recently (after your
patch that added the declaration here). So you couldn't have known.


--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Olliver Schinagl March 12, 2015, 9 a.m. UTC | #4
Hey all,

On 11-03-15 15:23, Rojhalat Ibrahim wrote:
> On Wednesday 11 March 2015 13:48:16 Olliver Schinagl wrote:
>> Hey all,
>>
>> On 11-03-15 13:22, Rojhalat Ibrahim wrote:
>>> On Wednesday 11 March 2015 12:24:38 Linus Walleij wrote:
>>>> Commit 1feb57a245a4910b03202a814ffc51a900bd4aca
>>>> "gpio: add parameter to allow the use named gpios"
>>>> includes a double-conted array. Fix this.
>>>>
>>>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>>>> Cc: Olliver Schinagl <oliver@schinagl.nl>
>>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>>> ---
>>>>    drivers/gpio/devres.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
>>>> index ec24da2418b3..0bd060bf7151 100644
>>>> --- a/drivers/gpio/devres.c
>>>> +++ b/drivers/gpio/devres.c
>>>> @@ -135,7 +135,7 @@ struct gpio_desc *devm_get_gpiod_from_child(struct device *dev,
>>>>    					    const char *con_id,
>>>>    					    struct fwnode_handle *child)
>>>>    {
>>>> -	static const char const *suffixes[] = { "gpios", "gpio" };
>>>> +	static const char *suffixes[] = { "gpios", "gpio" };
>>>>    	char prop_name[32]; /* 32 is max size of property name */
>>>>    	struct gpio_desc **dr;
>>>>    	struct gpio_desc *desc;
>>>>
>>> Shouldn't it be const char * const suffixes[], as in a const pointer to const data?
>> I sent a patch to fix this weeks ago I belive.
>>> Wouldn't it be better to add an #include "gpiolib.h" to devres.c and use
>>> the gpio_suffixes array defined in gliolib.h?
>> I did not know we had that, that sounds logical. I can cook up a patch
>> for that to work on both invocations!
>>
> The gpio_suffixes array in gpiolib.h was added only very recently (after your
> patch that added the declaration here). So you couldn't have known.
Ah, fair enough. I'll rebase and make a patch then for it :)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/gpio/devres.c b/drivers/gpio/devres.c
index ec24da2418b3..0bd060bf7151 100644
--- a/drivers/gpio/devres.c
+++ b/drivers/gpio/devres.c
@@ -135,7 +135,7 @@  struct gpio_desc *devm_get_gpiod_from_child(struct device *dev,
 					    const char *con_id,
 					    struct fwnode_handle *child)
 {
-	static const char const *suffixes[] = { "gpios", "gpio" };
+	static const char *suffixes[] = { "gpios", "gpio" };
 	char prop_name[32]; /* 32 is max size of property name */
 	struct gpio_desc **dr;
 	struct gpio_desc *desc;