From patchwork Tue Feb 9 03:51:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 44876 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 825FCB7D01 for ; Tue, 9 Feb 2010 14:51:39 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753718Ab0BIDve (ORCPT ); Mon, 8 Feb 2010 22:51:34 -0500 Received: from mail-yx0-f193.google.com ([209.85.210.193]:58839 "EHLO mail-yx0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217Ab0BIDvd (ORCPT ); Mon, 8 Feb 2010 22:51:33 -0500 Received: by yxe31 with SMTP id 31so6405568yxe.21 for ; Mon, 08 Feb 2010 19:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:reply-to:mime-version:content-type:content-disposition :x-url:organization:user-agent:x-os; bh=IVd5FS4vD0gqYvOKL7+qEO4xHPnj5mKJhONszWZmkk4=; b=jGGWr+JkybEJFAh3aW03hRKdFBefnWgMsQ2ujg4S45xv4BMkAPy+WUTPioRHGZRCec g2mnohtxBpe4Bpf/rJ7bgyOuh2jVrtru5rhoAKTKhs19EqJQLgKCeIIGBuIfQfdo0pA+ j+cqVB79Okq7mEE5sIQDtikshxpMMUwb28j4U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:mime-version :content-type:content-disposition:x-url:organization:user-agent:x-os; b=sevMCOxEfxq0WnETW8fqYjyIx1I6KTb7zxI+SjeIOXnRMAeCvgRhiU/OhnCYFimAno U3lj/iIDflweVhf0Ahep4N0wa2OqN4UxnL7+Pjiu+Kc/BqbdrlQkUzqzflBcM0jrEofx H3rYzh5/qso7YYNS7Si2zBdMTleAjbkOPDxQU= Received: by 10.150.127.40 with SMTP id z40mr10089314ybc.308.1265687493063; Mon, 08 Feb 2010 19:51:33 -0800 (PST) Received: from serverengines.com ([124.30.166.146]) by mx.google.com with ESMTPS id 23sm1657767yxe.36.2010.02.08.19.51.29 (version=SSLv3 cipher=RC4-MD5); Mon, 08 Feb 2010 19:51:31 -0800 (PST) Date: Tue, 9 Feb 2010 09:21:26 +0530 From: Ajit Khaparde To: David Miller Cc: netdev Subject: [PATCH net-next-2.6] be2net: bug fix in be_read_eeprom Message-ID: <20100209035115.GA6577@serverengines.com> Reply-To: Ajit Khaparde MIME-Version: 1.0 Content-Disposition: inline X-URL: http://www.serverengines.com Organization: ServerEngines Corp User-Agent: "Ajit's Mutt" X-OS: Linux x86_64 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The offset to read the eeprom data was missing and wrong eeprom data was being dumped. This patch fixes this. From Suresh R Signed-off-by: Ajit Khaparde --- drivers/net/benet/be_ethtool.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/benet/be_ethtool.c b/drivers/net/benet/be_ethtool.c index 09d8899..dcc7f37 100644 --- a/drivers/net/benet/be_ethtool.c +++ b/drivers/net/benet/be_ethtool.c @@ -614,7 +614,7 @@ be_read_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom, if (!status) { resp = (struct be_cmd_resp_seeprom_read *) eeprom_cmd.va; - memcpy(data, resp->seeprom_data, eeprom->len); + memcpy(data, resp->seeprom_data + eeprom->offset, eeprom->len); } pci_free_consistent(adapter->pdev, eeprom_cmd.size, eeprom_cmd.va, eeprom_cmd.dma);