| Message ID | 1425985583-26279-2-git-send-email-geert+renesas@glider.be |
|---|---|
| State | New |
| Headers | show |
On Tue, Mar 10, 2015 at 12:06 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Register and field widths are in the range 1..32. Storing them in the > pinctrl data in (arrays of) unsigned long wastes space. > > This decreases the size of a (32-bit) shmobile_defconfig kernel > supporting 7 SoCs by 26460 bytes. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v2: > - Add Acked-by. Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Mar 18, 2015 at 2:10 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Mar 10, 2015 at 12:06 PM, Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > >> Register and field widths are in the range 1..32. Storing them in the >> pinctrl data in (arrays of) unsigned long wastes space. >> >> This decreases the size of a (32-bit) shmobile_defconfig kernel >> supporting 7 SoCs by 26460 bytes. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> --- >> v2: >> - Add Acked-by. > > Patch applied. Oh newer version exists, sigh, back out try the newer one... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/sh-pfc/core.c b/drivers/pinctrl/sh-pfc/core.c index 895a41e2f30aefc8..5591baf9738b5de9 100644 --- a/drivers/pinctrl/sh-pfc/core.c +++ b/drivers/pinctrl/sh-pfc/core.c @@ -209,7 +209,7 @@ static void sh_pfc_write_config_reg(struct sh_pfc *pfc, sh_pfc_config_reg_helper(pfc, crp, field, &mapped_reg, &mask, &pos); dev_dbg(pfc->dev, "write_reg addr = %lx, value = 0x%x, field = %ld, " - "r_width = %ld, f_width = %ld\n", + "r_width = %u, f_width = %u\n", crp->reg, value, field, crp->reg_width, crp->field_width); mask = ~(mask << pos); diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h index ed5cf4192fa1a2d0..6aeec8152ea674cf 100644 --- a/drivers/pinctrl/sh-pfc/sh_pfc.h +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h @@ -69,9 +69,10 @@ struct pinmux_func { }; struct pinmux_cfg_reg { - unsigned long reg, reg_width, field_width; + unsigned long reg; + u8 reg_width, field_width; const u16 *enum_ids; - const unsigned long *var_field_width; + const u8 *var_field_width; }; #define PINMUX_CFG_REG(name, r, r_width, f_width) \ @@ -80,12 +81,13 @@ struct pinmux_cfg_reg { #define PINMUX_CFG_REG_VAR(name, r, r_width, var_fw0, var_fwn...) \ .reg = r, .reg_width = r_width, \ - .var_field_width = (const unsigned long [r_width]) \ + .var_field_width = (const u8 [r_width]) \ { var_fw0, var_fwn, 0 }, \ .enum_ids = (const u16 []) struct pinmux_data_reg { - unsigned long reg, reg_width; + unsigned long reg; + u8 reg_width; const u16 *enum_ids; };