diff mbox

pc-dimm: Add description for device list.

Message ID 1425984177-10608-1-git-send-email-paulo.vital@profitbricks.com
State New
Headers show

Commit Message

Paulo Ricardo Paz Vital March 10, 2015, 10:42 a.m. UTC 
The pc-dimm option presented on device list (by argument "-device \?")
is the unique option that don't have any information about it. This
patch adds a description for the pc-dimm device to help users to
identify it.

Signed-off-by: Paulo Vital <paulo.vital@profitbricks.com>
---
 hw/mem/pc-dimm.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Igor Mammedov March 10, 2015, 11:06 a.m. UTC | #1 
On Tue, 10 Mar 2015 11:42:57 +0100
Paulo Vital <paulo.vital@profitbricks.com> wrote:

> The pc-dimm option presented on device list (by argument "-device \?")
> is the unique option that don't have any information about it. This
> patch adds a description for the pc-dimm device to help users to
> identify it.
> 
> Signed-off-by: Paulo Vital <paulo.vital@profitbricks.com>
> ---
>  hw/mem/pc-dimm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
> index de81b9c..d3f7b5b 100644
> --- a/hw/mem/pc-dimm.c
> +++ b/hw/mem/pc-dimm.c
> @@ -351,6 +351,7 @@ static void pc_dimm_class_init(ObjectClass *oc, void *data)
>  
>      dc->realize = pc_dimm_realize;
>      dc->props = pc_dimm_properties;
> +    dc->desc = "Dimm device for Memory Hotplug";
it's not necessarily only for hotplug, I'd suggest:
"DIMM memory module"

>  
>      ddc->get_memory_region = pc_dimm_get_memory_region;
>  }
diff mbox

Patch

diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index de81b9c..d3f7b5b 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -351,6 +351,7 @@  static void pc_dimm_class_init(ObjectClass *oc, void *data)
 
     dc->realize = pc_dimm_realize;
     dc->props = pc_dimm_properties;
+    dc->desc = "Dimm device for Memory Hotplug";
 
     ddc->get_memory_region = pc_dimm_get_memory_region;
 }